FvwmPager: Restart shows incorrect second monitor state

[Athanasius]

Upfront Information

• Fvwm3 version (run: fvwm3 --version): fvwm3 1.1.1 (1.1.0-89-g3ce31b32e-dirty)

• Linux distribution or BSD name/version: Debian 12/bookworm

• Platform (run: uname -sp): Linux unknown

Expected Behaviour

Upon triggering Restart all FvwmPager pages, no matter the desk or page, should display state correctly.

Actual Behaviour

With the default-config, viewing Page 1 (out of 0 1 2 3) upon triggering Restart, FvwmPager incorrectly shows that Page 0 is active, when Page 1 is still active. Clicking the 1 causes no change, but upon activating any other page the shown state updates correctly.

With a more complex Page/Desk setup an extra issue of some applications being attributed to Page 0,0 is also evident. Again, once the active Page (for the relevant Desk) is changed, the state updates to showing correctly.

Enabling logging

Steps to Reproduce

This is using /usr/share/fvwm3/default-config/config as per a build of a Debian package from the upstream source with https://github.com/somiaj/fvwm3-debian.git debian/ files for the build.

With a slightly more complex configuration that has:

1. Two desks, one per monitor.
2. 3x2 pages on each desk.
3. DesktopConfiguration shared.

This also has the "incorrect page shown active", but the outcome is worse in that now at least some of the application windows are shown piled up in page 0,0 of desk 1, rather than on their appropriate pages. Weirdly it's not always all of them. Again, this corrects when the viewed page is changed on that desk.

Does Fvwm3 crash?

No crashes.

Extra Information

fvwm3-output.log showed nothing of interest.

Videos:

1. Using default-config - https://github.com/user-attachments/assets/04f619b1-e000-401e-9feb-5db1a4f072cd
2. Using a minimal config for 3x2 pages / two desks - https://github.com/user-attachments/assets/4675fcd1-6918-4fe4-b99a-72d490920f26
3. Configuration for the 3x2 page on each of two desks is: issue-1082-min-config.d.tar.gz

[somiaj]

@Athanasius do you still experience this issue using the main branch? Was the second monitor on a desktop other than zero during the restart? There was a fix to deal with FvwmPager not showing the correct desktop after a restart in a different case, and am wondering if it happened to fix this issues as well.

[Athanasius]

@Athanasius do you still experience this issue using the main branch? Was the second monitor on a desktop other than zero during the restart? There was a fix to deal with FvwmPager not showing the correct desktop after a restart in a different case, and am wondering if it happened to fix this issues as well.

Using: fvwm3.git == 04e71bc (main)
And: fvwm3-debian.git == 27d552608083260d080606f4b34eca2154843f7c (fvwm3-git)

1. With the default configuration a restart still causes the "active page" status to erroneously show as on page 0, despite being on either page 2 or 3 when restart is triggered. The correct windows for the "before restart" page are still being displayed after the restart, i.e. this is only about the status that FvwmPager shows.

2. With my more complicated 2-desk setup (which has two desks, with DesktopConfiguration shared, FvwmPager per desk), after a restart:

   1. The FvwmPager on desk 0 shows mostly correct state. It is liable to show some minimised window icons on an incorrect page at times, mostly the two sticky XTerms I have.
   2. The FvwmPager on desk 1 stops showing correct "active page" state.
   3. The FvwmPager on desk 1 is also not showing that there are any windows on desk 1.
   4. The FvwmPager on desk 1 does not show windows newly opened after the restart.
   5. The FvwmPager on desk 1 is also showing a phantom iconised window on page 2,1 where there is no such window before or after the restart on either desk.
   6. LMB click on FvwmPager on desk 1 does not change active page. My Key Up A C Scroll +0 -100 key binds to change pages do work, i.e. active page state updates.
   7. After using the MonitorLabels on the FvwmPager on desk 1 to change to the desk 0 and back to desk 1it is once more functioning correctly. Presumably the correct state got forced by the switch.

And, yes, in this setup I almost always have primary (left) monitor on desk 0, and secondary (right) monitor on desk 1. That's the whole point of this setup. They would be in this state on any restart testing. If it matters, I specifically trigger the restart on the primary monitor displaying desk 0.

I should probably open a specific issue (possibly multiple, but they feel related) for these 2-desk-setup issues. I've been avoiding even testing it as it can be such a pain to get things back into a sane state again. There's the complication of Firefox seemingly ignoring most fvwm management of its windows positions and desk/page placement, such that sometimes I struggle to even get a Firefox window to display anywhere for further interaction. That is a whole separate issue that I'm fully prepared to blame Firefox for, but perhaps some fvwm3 code changes could at least reduce the impact.