-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash #7
Comments
What compose version are you using in that project? |
Latest, 1.5.0-beta01 👀 |
It looks like in the waveslider library we use the compose BOM package so you could try that. It was automatically created by Android Studio as version |
The thing that worked, is that I copied the module to the project, and bumped compose to 1.5.0-beta01, and had to downgrade minSdk to 21, have no idea, why 26 used here, cause compose needs 21 only |
Oh so it doesn't crash when minSdk is 21? |
No, I meant that there is no point in putting 26 if everything works with 21 👀 |
And with the latest compose version it also doesn't crash |
Merged PR updating mikSdk, and I found that the latest compose BOM is what is currently in the project so I changed it to individual dependencies, however while the compose version and material versions are updated to the latest one, it breaks the current implementation of the steps because they changed some values to be internal only that we were using to calculate the position of each tick :( |
Yes! But i found solution, how to fix it 👀 |
Just copy private function, which creates step fractions, and that's it :) |
I found the solution !
with this :
Changes : Slider.kt · Gerrit Code Review I found the stepsToTickFractions function : here Here is the new file, just create new kt file "WaveSlider.kt" and paste this code :
I hope the developer implement it as soon as possible |
Wow, thanks for that, i'll be waiting too, maybe you can open PR? |
Do you mean pull request ? |
@YounesBouhouche did you noticed Layout Node not attached to owner exception after updating to 1.2.0-06 or 07-08 ? |
You need to fork the project and then apply your changes in your fork, and then open pull request on GitHub |
No I didn't |
:( |
Hi all, got back to maintaining this project and I have updated WaveSlider.kt with the fix in this commit [cbab52b] @T8RIN @YounesBouhouche Does this address the issue? |
I have no idea, why this happens, maybe that's because i use newer compose version...
The text was updated successfully, but these errors were encountered: