Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin CI: replace AppVeyor by GitHub Actions #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cygwin CI: replace AppVeyor by GitHub Actions #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0594cdd
CI: add a Cygwin job
wilfwilson Jan 27, 2022
28581c5
Remove AppVeyor
wilfwilson Jan 27, 2022
babcca3
Add a .gitattributes file
wilfwilson Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .appveyor.yml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto eol=lf
17 changes: 17 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,23 @@ jobs:
- uses: gap-actions/process-coverage@v2
- uses: codecov/codecov-action@v2

test-cygwin:
name: "master cygwin64 - HPC no"
if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) }}
runs-on: windows-latest
env:
CHERE_INVOKING: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to understand: why do we need this here? don't all the actions already set it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not necessary here. However, in my opinion it is not worth my time to remove it and wait to see if it works.

However, I think it would be required if one ever added a step to this job that ran some commands directly in the Cygwin bash shell. Keeping this (otherwise harmless) environment variable set means that adding such a step would be as seamless as possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rebase, I've commented it out for now.

Copy link
Member Author

@wilfwilson wilfwilson Jan 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it does need to be there, I don't really understand why, but if it's not then gap-actions/build-pkg and gap-actions/run-pkg-tests start in the GAP directory, and not in the ace directory, and so they fail at building the package and running its tests, respectively.

Here's an example of it running without the environment variable set: https://github.com/gap-packages/ace/runs/4965188634?check_suite_focus=true

steps:
- uses: actions/checkout@v2
- uses: gap-actions/setup-cygwin@v1
- uses: gap-actions/setup-gap@cygwin-v2
fingolfin marked this conversation as resolved.
Show resolved Hide resolved
with:
GAP_PKGS_TO_BUILD: ''
- uses: gap-actions/build-pkg@cygwin-v1
- uses: gap-actions/run-pkg-tests@cygwin-v2
with:
NO_COVERAGE: 'yes'

# The documentation job
manual:
name: Build manuals
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[![Build Status](https://github.com/gap-packages/ace/workflows/CI/badge.svg?branch=master)](https://github.com/gap-packages/ace/actions?query=workflow%3ACI+branch%3Amaster)
[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/gap-packages/ace?branch=master&svg=true)](https://ci.appveyor.com/project/gap-packages/ace)
[![Code Coverage](https://codecov.io/github/gap-packages/ace/coverage.svg)](https://codecov.io/gh/gap-packages/ace)


Expand Down