Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW not properly checked for in macros. #102

Open
MakoEnergy opened this issue Sep 27, 2016 · 0 comments
Open

MinGW not properly checked for in macros. #102

MakoEnergy opened this issue Sep 27, 2016 · 0 comments

Comments

@MakoEnergy
Copy link

MakoEnergy commented Sep 27, 2016

I am here due to some difficulties trying to get Bullet3 up and running on MinGW. In Macros.h windows is checked for using "_WIN32" and then uses non-portable versions of functions (vsnprintf_s, for example) available only in MSVC. This is a problem since MSVC isn't the only compiler available on Windows.

The
#ifdef _WIN32
should be replaced with
#ifdef _MSC_VER
if the intent is to use MSVC specific features.

The
#elif defined(__linux__)
should also probably be replaced with
#elif defined(__linux__) || defined(__GNUC__).

In the case of MinGW, the __GNUC__ would be detected and used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant