Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: gatsby-plugin-s3 #24

Open
2 of 9 tasks
jariz opened this issue Aug 2, 2021 · 10 comments
Open
2 of 9 tasks

add: gatsby-plugin-s3 #24

jariz opened this issue Aug 2, 2021 · 10 comments
Labels
new-plugin Submit a plugin for inclusion

Comments

@jariz
Copy link

jariz commented Aug 2, 2021

Info

Overview

Hi, I saw this repo and I think it quite fits with my situation.
I maintain gatsby-plugin-s3, the recommended way to deploy to S3 in the gatsby docs itself.
I've largely declared the project as 'done' as it has generally achieved all the goals I personally set out for it, however, there's still quite the backlog of additional features people would like to see.
Me and my co-maintainer have largely moved on from this project however.
People have suggested me to ask Gatsby itself to pick up the plugin, but because it is a direct concurrent of their own service, I very much doubt they're interested in picking it up. 😉

Tasks

Contributor Tasks:

Admin Tasks:

  • Move Code into gatsby-uc/plugins repo
    • Update Readme in old repo to redirect folks to new location
    • Archive old Repo
    • Close any irrelevant PRs/Issues
    • Move/Comment on still applicable issues
  • Update Plugin with best practices
  • Publish new version
@jariz jariz added the new-plugin Submit a plugin for inclusion label Aug 2, 2021
@moonmeister
Copy link
Contributor

Hello! This is the perfect case for moving this here. Thanks for the contribution.

There's a couple things only you can do:

  • Transfer the GitHub repo to this org. (GitHub wil automatically redirect folks with the old url)
  • Add me (moonmeister) as a collaborator (write access) on the npm package and I'll give the gatsby-uc publisher's team access (for now it's just me).

https://docs.npmjs.com/adding-collaborators-to-private-packages-owned-by-a-user-account

I've sent you an invite to the NPM org and GitHub Org.

Finally, if you have time to open a PR for merging the plugin into this repo that'd be great, if not I should have time.

@moonmeister moonmeister changed the title add[plugin-name]: gatsby-plugin-s3 add: gatsby-plugin-s3 Aug 2, 2021
@moonmeister
Copy link
Contributor

the one thing I don't know how to handle would be moving issues/PRs from the current repo. I'll take a look once the repo is over and see what can be done. I'm not against leaving it in it's own repo if that's better.

@jariz
Copy link
Author

jariz commented Aug 3, 2021

Hi, great!
I'll look into this somewhere today / tomorrow.
I'm fine with creating the PR myself.

@moonmeister
Copy link
Contributor

Still hoping to get this done if you have time @jariz

@moonmeister moonmeister self-assigned this Sep 13, 2021
@moonmeister
Copy link
Contributor

moonmeister commented Jan 13, 2022

Hey @jariz , I'll be talking at Gatsby Conf in March regarding the GUC and some of the cool plugins we are maintaining. I'd love for gatsby-plugin-s3 to be apart of that. Let me know if you have any questions. The two actions I need from you (moving the repo and giving me npm permissions) shouldn't take more than 5 minutes. Some time this week or next would be prefered. Thanks!

@moonmeister moonmeister removed their assignment Sep 8, 2022
@YoshiWalsh
Copy link

Hi @moonmeister ,

Sorry for the lengthy delay on this one, my life has been busy recently. I tried transferring the repo and it said "You don’t have the permission to create public repositories on gatsby-uc". Could you please add me to the org?

Thanks,
Josh

@moonmeister
Copy link
Contributor

@JoshuaWalsh Invite sent!

@YoshiWalsh
Copy link

I have transferred the repository and added you to the npm package. Regarding moving in to the monorepo, gatsby-plugin-s3 already has a monorepo structure (in order to house our test suite and example projects). How do you want to handle this? Should we nest our existing projects in a folder within the UC monorepo, or should we make all our projects top-level within the UC monorepo?

@moonmeister
Copy link
Contributor

Thanks Josh. I'll see about getting this into the monorepo unless you are able to.

@moonmeister
Copy link
Contributor

moonmeister commented Jun 30, 2023

Oops, missed the questions you asked. We have a folder for full Gatsby sites that implement testing - integration-tests. If you have more unit testing those can go along side the plugin in its folder. As for examples, I think creating a top-level 'examples` folder would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-plugin Submit a plugin for inclusion
Projects
None yet
Development

No branches or pull requests

3 participants