Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency errors and root module errors should not block the rest of tach check #488

Open
emdoyle opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@emdoyle
Copy link
Member

emdoyle commented Dec 19, 2024

Right now, when we build the 'module tree' from the tach.toml configuration, we validate against circular dependencies and the expected root module treatment (if necessary). However, when these checks fail, we immediately return an error and render it in the CLI.

Instead, the tach check command should continue with a full scan for errors even when these validations fail. The validation errors can be displayed in their own segment of the error output.

@emdoyle emdoyle added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant