-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the instruction documentation #1561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this thorough improvement! I have comparatively few nitpicks.
I wonder what @nummacway thinks?
Damn the diff is impossible to read with just one word per line. How do manpage maintainers do this? Two comments of the things I can decipher:
|
Thanks for your feedback!
|
One important thing: The "bitwise NOT" was not meant for CCF but CPL. Because CCF affects a flag which is basically a boolean, CCF would be called the "logical NOT". I personally wouldn't even use a term here at all, but say that this "inverts" or "flips the carry flag", though I'm not sure if this wording makes sense to other people and where to put this. |
You could also call CPL the "subtraction from 255" (A = 255-A). |
|
Note that using Split diff (click the little cog menu in the Files tab) is much more readable, at least for this kind of diff. (I sometimes switch back to Unified for some code changes, but rarely.) I agree that “bitwise NOT” should be called out for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed another thing—you certainly are far more thorough than I! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this very thorough improvement ^^
Fixes #1560:
STOP
's second byte.u3
as a bit index.CPL
.And does more cleanup:
A
to the bitwise OP between arg andA
" for bitwise AND/OR/XOR.HALT
explanation to matchDAA
: