add validation to match database constraints #657

(cherry picked from commit 817026e)

Author: ahakanzn

pom.xml

@@ -88,7 +88,7 @@
     <spring-cloud-sleuth.version>2.2.8.RELEASE</spring-cloud-sleuth.version>
 
     <!-- GBIF -->
-    <gbif-api.version>2.0.4</gbif-api.version>
+    <gbif-api.version>2.0.5-SNAPSHOT</gbif-api.version>
     <gbif-common.version>0.59</gbif-common.version>
     <gbif-common-mybatis.version>2.0.0</gbif-common-mybatis.version>
     <gbif-common-ws.version>2.0.0</gbif-common-ws.version>

registry-integration-tests/src/test/java/org/gbif/registry/ws/it/collections/service/suggestions/BaseChangeSuggestionServiceIT.java

@@ -599,7 +599,7 @@ public void updateContactsTest() {
       .filter(c -> c.getKey().equals(contact1.getKey()))
       .findFirst()
       .get()
-      .setModifiedBy("11");
+      .setModifiedBy("111");
 
     R suggestion3 = createEmptyChangeSuggestion();
     suggestion3.setSuggestedEntity(entity);
@@ -614,6 +614,23 @@ public void updateContactsTest() {
     // Then
     suggestion3 = changeSuggestionService.getChangeSuggestion(sugg3Key);
     assertEquals(0, suggestion3.getChanges().size());
+
+    // suggestion to change contact1 with an invalid name
+    entity.getContactPersons().stream()
+      .filter(c -> c.getKey().equals(contact1.getKey()))
+      .findFirst()
+      .get()
+      .setFirstName("");
+
+    R suggestion4 = createEmptyChangeSuggestion();
+    suggestion4.setSuggestedEntity(entity);
+    suggestion4.setType(Type.UPDATE);
+    suggestion4.setEntityKey(entityKey);
+    suggestion4.setProposerEmail(PROPOSER);
+    suggestion4.setComments(Collections.singletonList("contact1"));
+
+    assertThrows(ValidationException.class,
+      () -> changeSuggestionService.createChangeSuggestion(suggestion4));
   }
 
   protected void assertCreatedSuggestion(R created) {