Skip to content

Commit b84746d

Browse files
Fix merge conflicts with PR #1000
1 parent 59b452f commit b84746d

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

java/src/main/java/com/genexus/internet/HttpClientJavaLib.java

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -74,45 +74,41 @@ public class HttpClientJavaLib extends GXHttpClient {
7474
return allIps;
7575
};
7676

77-
private static String getGxIpResolverConfig() {
77+
private static boolean isFirstIpDnsEnabled() {
7878
String name = "GX_USE_FIRST_IP_DNS";
7979
String gxDns = System.getProperty(name);
8080
if (gxDns == null || gxDns.trim().isEmpty()) {
8181
gxDns = System.getenv(name);
8282
}
83-
if (gxDns != null && gxDns.trim().equalsIgnoreCase("true")) {
84-
return gxDns.trim();
85-
} else {
86-
return null;
87-
}
83+
return gxDns != null && gxDns.trim().equalsIgnoreCase("true");
8884
}
8985

90-
9186
public HttpClientJavaLib() {
9287
getPoolInstance();
9388
ConnectionKeepAliveStrategy myStrategy = generateKeepAliveStrategy();
9489
HttpClientBuilder builder = HttpClients.custom()
9590
.setConnectionManager(connManager)
9691
.setConnectionManagerShared(true)
9792
.setKeepAliveStrategy(myStrategy);
98-
if (getGxIpResolverConfig() != null) {
99-
builder.setDnsResolver(new FirstIpDnsResolver());
93+
if (isFirstIpDnsEnabled()) {
94+
builder.setDnsResolver(FIRST_IP_DNS_RESOLVER);
10095
}
10196
httpClientBuilder = builder;
102-
cookies = new BasicCookieStore();
97+
cookies = new BasicCookieStore();
10398
streamsToClose = new Vector<>();
10499
}
105100

106101
private static void getPoolInstance() {
107102
if(connManager == null) {
108103
Registry<ConnectionSocketFactory> socketFactoryRegistry =
109104
RegistryBuilder.<ConnectionSocketFactory>create()
110-
.register("http", PlainConnectionSocketFactory.INSTANCE).register("https",getSSLSecureInstance())
105+
.register("http", PlainConnectionSocketFactory.INSTANCE).register("https", getSSLSecureInstance())
111106
.build();
112-
boolean useCustomDnsResolver = getGxIpResolverConfig() != null;
113-
PoolingHttpClientConnectionManager connManager = useCustomDnsResolver
114-
? new PoolingHttpClientConnectionManager(socketFactoryRegistry, new FirstIpDnsResolver())
115-
: new PoolingHttpClientConnectionManager(socketFactoryRegistry);
107+
if (isFirstIpDnsEnabled()) {
108+
connManager = new PoolingHttpClientConnectionManager(socketFactoryRegistry, FIRST_IP_DNS_RESOLVER);
109+
} else {
110+
connManager = new PoolingHttpClientConnectionManager(socketFactoryRegistry);
111+
}
116112
connManager.setMaxTotal((int) CommonUtil.val(clientCfg.getProperty("Client", "HTTPCLIENT_MAX_SIZE", "1000")));
117113
connManager.setDefaultMaxPerRoute((int) CommonUtil.val(clientCfg.getProperty("Client", "HTTPCLIENT_MAX_PER_ROUTE", "1000")));
118114

0 commit comments

Comments
 (0)