Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer selectable even if the group it belongs to is turned off #10632 #10680

Conversation

rowheat02
Copy link
Contributor

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

#10632

What is the current behavior?

The identify panel still shows results (even if the layer's group is not visible)

What is the new behavior?

Layers within invisible group will not show on identify on mapclick.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Also, Added .DS_Store to .gitignore to prevent macOS metadata files

@rowheat02 rowheat02 changed the title Fix/disableidentifyforinvisiblegroups Layer selectable even if the group it belongs to is turned off #10632 Nov 15, 2024
@rowheat02 rowheat02 self-assigned this Nov 15, 2024
@rowheat02 rowheat02 added the bug label Nov 15, 2024
@rowheat02 rowheat02 linked an issue Nov 15, 2024 that may be closed by this pull request
1 task
@rowheat02 rowheat02 added this to the 2024.02.02 milestone Nov 15, 2024
@tdipisa tdipisa requested a review from offtherailz November 15, 2024 13:26
@offtherailz offtherailz merged commit 26a90f9 into geosolutions-it:master Nov 18, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 20, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @rowheat02 please backport this on 2024.02.xx. Thanks

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer selectable even if the group it belongs to is turned off
4 participants