Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

widgets in map wrongly align with a specific config #10676 #10681

Merged
merged 1 commit into from
Nov 18, 2024
Merged

widgets in map wrongly align with a specific config #10676 #10681

merged 1 commit into from
Nov 18, 2024

Conversation

rowheat02
Copy link
Contributor

Description

Ignored rowheight from config(cfg) to calculate the baseheight of widget in small screens(isSingleWidgetLayout)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

#10676

What is the current behavior?

#10676

What is the new behavior?

In small screens, widget will not hide partially.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 self-assigned this Nov 15, 2024
@rowheat02 rowheat02 added this to the 2024.02.02 milestone Nov 15, 2024
@rowheat02 rowheat02 linked an issue Nov 15, 2024 that may be closed by this pull request
widgets in map wrongly align with a specific config #10676
Closed
1 task
@tdipisa tdipisa requested a review from offtherailz November 15, 2024 15:52
offtherailz
offtherailz approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.
Looks to be simply an old part of code missing. approved
image

@offtherailz offtherailz merged commit 7743c32 into geosolutions-it:master Nov 18, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 20, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @rowheat02 please backport to 2024.02.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Nov 21, 2024
@rowheat02
ignore rowheight for singleWidgetLayout (geosolutions-it#10681)
5d6f421
tdipisa pushed a commit that referenced this pull request Nov 21, 2024
@rowheat02
ignore rowheight for singleWidgetLayout (#10681) (#10689)
02811cc
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@rowheat02 rowheat02

Labels
bug Regression
Projects
None yet
Milestone
2024.02.02
Development

Successfully merging this pull request may close these issues.

widgets in map wrongly align with a specific config
4 participants
@rowheat02 @offtherailz @ElenaGallo @tdipisa