-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10695 Handle empty values for and/or/not/nor filters #10696
Merged
tdipisa
merged 3 commits into
geosolutions-it:master
from
offtherailz:fix_filter_builder
Nov 27, 2024
Merged
Fix #10695 Handle empty values for and/or/not/nor filters #10696
tdipisa
merged 3 commits into
geosolutions-it:master
from
offtherailz:fix_filter_builder
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Nov 27, 2024
MV88
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Matteo V. <[email protected]>
MV88
approved these changes
Nov 27, 2024
@ElenaGallo please check in DEV on deployed and let us know for the backport. |
Test passed, @MV88 please backport. Thanks |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Dec 2, 2024
…ers (geosolutions-it#10696) * Fix geosolutions-it#10695 Handle empty values for and/or/not/nor filters * Update web/client/utils/ogc/Filter/operators.js Co-authored-by: Matteo V. <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Matteo V. <[email protected]>
tdipisa
pushed a commit
that referenced
this pull request
Dec 2, 2024
…10704) * Fix #10695 Handle empty values for and/or/not/nor filters * Update web/client/utils/ogc/Filter/operators.js * Apply suggestions from code review --------- Co-authored-by: Matteo V. <[email protected]>
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR avoids the
<ogc:And>undefined</ogc:And>
in OGC filters that happens when having an empty filter.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10695
What is the new behavior?
Fix #10695
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information