Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10695 Handle empty values for and/or/not/nor filters #10696

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

offtherailz
Copy link
Member

Description

This PR avoids the <ogc:And>undefined</ogc:And> in OGC filters that happens when having an empty filter.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10695

What is the new behavior?

Fix #10695

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz self-assigned this Nov 27, 2024
@offtherailz offtherailz added this to the 2024.02.02 milestone Nov 27, 2024
@offtherailz offtherailz requested a review from MV88 November 27, 2024 13:28
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2024
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web/client/utils/ogc/Filter/__tests__/operators-test.js Outdated Show resolved Hide resolved
web/client/utils/ogc/Filter/operators.js Outdated Show resolved Hide resolved
@offtherailz offtherailz requested a review from MV88 November 27, 2024 17:07
@tdipisa tdipisa merged commit e0fbce0 into geosolutions-it:master Nov 27, 2024
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Nov 27, 2024

@ElenaGallo please check in DEV on deployed and let us know for the backport.

@ElenaGallo
Copy link
Contributor

Test passed, @MV88 please backport. Thanks

offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Dec 2, 2024
…ers (geosolutions-it#10696)

* Fix geosolutions-it#10695 Handle empty values for and/or/not/nor filters

* Update web/client/utils/ogc/Filter/operators.js

Co-authored-by: Matteo V. <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Matteo V. <[email protected]>
tdipisa pushed a commit that referenced this pull request Dec 2, 2024
…10704)

* Fix #10695 Handle empty values for and/or/not/nor filters

* Update web/client/utils/ogc/Filter/operators.js



* Apply suggestions from code review

---------

Co-authored-by: Matteo V. <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WFS requests from mapstore by default return a filter <ogc:And>undefined</ogc:And>
4 participants