[Issue #583] Add series dependencies #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the "dependencies" and "dependents" fields to the series detail view. Signed-off-by: Adam Hassick <[email protected]>
Add a ManyToMany field to represent a dependency relationship between patch series. Signed-off-by: Adam Hassick <[email protected]>
Add a new function to parse "Depends-on" tags to the parser. The value may either be a "reference" to a patch or series object or the web URL to the object. For example, a reference may look like "patch-1234" or "series-5678". When this tag is found, the parser will add the series (or the series the patch belongs to) as a dependency to the patch series it is creating. Signed-off-by: Adam Hassick <[email protected]>
Some operators of Patchwork instances may not want to allow series dependencies. By providing this setting, these operators may disable this behavior on their instance. Signed-off-by: Adam Hassick <[email protected]>
Add version 1.4 because new fields were added to the API.
Update the OpenAPI specification template and the API docs to reflect the new minor version. Signed-off-by: Adam Hassick <[email protected]>
Signed-off-by: Adam Hassick <[email protected]>
* Adds tests for the API and parser changes. * Add new test mbox files. * Add new patch series tests. Signed-off-by: Adam Hassick <[email protected]>
Signed-off-by: Adam Hassick <[email protected]>
|
I've reviewed all this on the list and am happy to keep doing so there, unless you'd rather do it here. Please let me know and optionally close this PR. |
|
I've replied to the comments on the mailing list. Next revision of this will be sent to the list as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new field to the Series model which represents a dependency between two series. The parser will search for "Depends-on" tags in the incoming emails and form the relationship. Patchwork clients, when applying a series with dependencies, can access this information through the API and apply the dependent series. Adds new "dependencies" and "dependents" fields to the API series detail view, and increments the API version to 1.4.
Because some projects may not want to use this feature on their instance, the "Depends-on" tag parsing is disabled by default, and can be enabled through the
ENABLE_DEPENDS_ON_PARSINGsetting.Related