Add isCrashed() property in SentryEvent Model

[KimTaeHyeong17]

Problem Statement

As implementing Sentry sdk in both android and ios device, we wanted to make sure to implement same way in both os.

There were some difference in android/iOS sentry interface but one thing I hoped to be added is "isCrashed" property.

As an ios developer who wanted to distinguish crash event and normal event at beforeSend closure, I tried to find flag to whether event is crash event and I was able to find only at android sdk.

After that I was started to think what's the difference between event.logLevel fatal and isCrashed value
I planned to use loglevel fatal in ios, and isCrahsed in android but it seems bit wrong for determine crash event.
After getting answer from sentry team about this question and I understood clearly.

However if there is "isCrahsed" in sentry-cocoa too, it would be much clear for this usecase.

Solution Brainstorm

- (BOOL)isCrash
{
    for (SentryException *exception in self.exceptions) {
        if (exception.mechanism != nil) {
            return YES;
        }
    }
    return NO;
}

Are you willing to submit a PR?

No response

[philipphofmann]

We already have that; we need to make it public. We could consider making isAppHangEvent and isMetricKitEvent public too.

sentry-cocoa/Sources/Sentry/include/SentryEvent+Private.h

Lines 11 to 35 in 1928267

	@property (nonatomic) BOOL isCrashEvent;
	/**
	* This indicates whether this event represents an app hang.
	*/
	@property (nonatomic, readonly) BOOL isAppHangEvent;
	/**
	* We're storing serialized breadcrumbs to disk in JSON, and when we're reading them back (in
	* the case of OOM), we end up with the serialized breadcrumbs again. Instead of turning those
	* dictionaries into proper SentryBreadcrumb instances which then need to be serialized again in
	* SentryEvent, we use this serializedBreadcrumbs property to set the pre-serialized
	* breadcrumbs. It saves a LOT of work - especially turning an NSDictionary into a SentryBreadcrumb
	* is silly when we're just going to do the opposite right after.
	*/
	@property (nonatomic, strong) NSArray *serializedBreadcrumbs;
	#if SENTRY_TARGET_PROFILING_SUPPORTED
	@property (nonatomic) uint64_t startSystemTime;
	@property (nonatomic) uint64_t endSystemTime;
	#endif // SENTRY_TARGET_PROFILING_SUPPORTED
	#if SENTRY_HAS_METRIC_KIT
	- (BOOL)isMetricKitEvent;
	#endif // SENTRY_HAS_METRIC_KIT

We will discuss this internally and get back to you.

[philipphofmann]

We need to make all the public properties exposed in this PR read-only, and we agree that we can make these properties public. Feel free to open a PR to make these public, @KimTaeHyeong17.