Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Grouping of crash events cause no thread has crashed true #4578

Open
arnavgupta180 opened this issue Nov 27, 2024 · 3 comments
Open

Comments

@arnavgupta180
Copy link

Platform

macOS

Environment

Production

Installed

Swift Package Manager

Version

8.36

Xcode Version

15.4

Did it work on previous versions?

No response

Steps to Reproduce

No steps to repro, Issue happens randomly

Expected Result

All crash events groups should have similar report.

Actual Result

For the below group we have different stack traces for different events:
https://citrix-workspace.sentry.io/issues/5782612431/events/98609bd2abc448bc8b236e992924f953/?project=4507448592105472&query=error.unhandled%3Atrue%20is%3Aunresolved&referrer=next-event&sort=freq&statsPeriod=14d&stream_index=1

stack trace: 39a6d7eaff9040e2bee50fea7fa444a4
stack trace: 98609bd2abc448bc8b236e992924f953

Are you willing to submit a PR?

No response

@philipphofmann
Copy link
Member

All these C++ Exceptions are grouped by the exception type, not the value. So you want that Sentry also includes the stacktrace for grouping? If yes, that totally makes sense, and we must investigate why that is and fix it.

Image

@arnavgupta180
Copy link
Author

arnavgupta180 commented Nov 28, 2024

yes, We want to group based on stack trace as well. There is another instance for different stack traces:

Sentry Group link: https://citrix-workspace.sentry.io/issues/5889315885/events/ff75ad4fc2234f1287833923c2d6cb[…]lved&referrer=next-event&statsPeriod=30d&stream_index=1

1 event id: ff75ad4fc2234f1287833923c2d6cbc1
2 event id: 39f312ee44db4ae1ab217ed8d7473957

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 28, 2024
@philipphofmann
Copy link
Member

Image

I found the reason why Sentry doesn't group it by stacktrace:
thread (ignored because does not contain exactly one crashing, one current or just one thread, instead contains 19 threads).
I checked the JSON payload of your event and can confirm that no thread has the property crashed set to true. We now need to identify what causes this, but I can't give you an ETA yet, when we will fix this.

@philipphofmann philipphofmann changed the title Grouping of crash events is not proper Broken Grouping of crash events cause no thread has crashed true Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Needs Discussion
Development

No branches or pull requests

2 participants