Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data comparisons in tests to ignore dict entries order #4625

Open
krystofwoldrich opened this issue Dec 12, 2024 · 0 comments
Open

Update Data comparisons in tests to ignore dict entries order #4625

krystofwoldrich opened this issue Dec 12, 2024 · 0 comments

Comments

@krystofwoldrich
Copy link
Member

Description

#4622 and #4624 were closed and we could not continue with implementation in Swift as all tests comparing serialized data became super flaky after the changes.

The reason for the flakiness was Data comparison in tests which relies on stable deterministic order of serialized objects.

In theory this should be already issue in Obj-C but with conversion to Swift the issue exploded.

Possible solutions

  • Update serialization to ensure deterministic order of dict entries
  • Update test to compare deserialized values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

1 participant