Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload Flutter framework debug symbols #173

Open
vaind opened this issue Oct 27, 2023 · 4 comments
Open

Don't upload Flutter framework debug symbols #173

vaind opened this issue Oct 27, 2023 · 4 comments

Comments

@vaind
Copy link
Collaborator

vaind commented Oct 27, 2023

Now that we've started collecting iOS, macOS and Android debug symbols in getsentry/sentry-dart#1673 we should stop uploading the incomplete symbols that ara available in the local build folder. They're not useful to show any debug information and are just a waste of resources (build time, bandwidth, storage).

@denrase
Copy link
Collaborator

denrase commented Apr 15, 2024

@vaind Hey! Do you have a suggestion on how to implement this? AFAIk there is no option in sentry-cli to exclude files/folders ATM

@vaind
Copy link
Collaborator Author

vaind commented Apr 16, 2024

sentry-cli debug-files upload <optional-config-args> filename.so another-file.so ... is the command that uploads just the given files.

Instead of passing a directory, you can explicitly name the files that need to be uploaded. This reduces upload (build) time and saves storage on Sentry servers by not uploading files that are not needed for symbolication.

@denrase
Copy link
Collaborator

denrase commented Apr 23, 2024

@vaind Thx for the insight. How would we handle the macOS files expected in the integration test? Can those can be different, depending on what the application uses? Are they also collected outside of users doing the upload for their builds? I'm missing some context here.

@vaind
Copy link
Collaborator Author

vaind commented May 15, 2024

Those seem to be standard swift libraries so not part of the Flutter symbol upload cron. Although, being standard libraries I think they should be resolvable from standard symbol servers but better check with some folks from the cocoa SDK.

@denrase denrase removed their assignment Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants