Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry_dart_plugin default release version #250

Closed
ekuleshov opened this issue Jul 20, 2024 · 7 comments
Closed

sentry_dart_plugin default release version #250

ekuleshov opened this issue Jul 20, 2024 · 7 comments

Comments

@ekuleshov
Copy link

Environment

sentry_dart_plugin: 2.1.0

Steps to Reproduce

  1. run flutter packages pub run sentry_dart_plugin
  2. observe release uploaded to the Sentry web UI

Expected Result

The plugin docs says the release is constructed from the pubspec, so I'd expect release look like buildName+buildNumber.

My Sentry initialization sets release at runtime to buildName+buildNumber (matching with pubspec as it should be) and because of that uploaded symbols are not linked/not used with issues and I have two sets of releases shown in Sentry web UI.

Actual Result

The release is shown as buildName (buildNumber).

@buenaflor
Copy link
Contributor

My Sentry initialization sets release at runtime to buildName+buildNumber

you mean the release set by default through SentryFlutter.init?

@ekuleshov
Copy link
Author

you mean the release set by default through SentryFlutter.init?

That is correct

@buenaflor
Copy link
Contributor

@denrase could you have a look pls

@denrase
Copy link
Collaborator

denrase commented Jul 30, 2024

@ekuleshov Could you sahre the code with us where you set buildName+buildNumber? If the values from pubspec.yaml are the ones you want, you do not have to set this explicitly in options setup.

@ekuleshov
Copy link
Author

I'm using the package_info_plus to get the version info:

      PackageInfo pi = await PackageInfo.fromPlatform();
      _appVersion = '${pi.version}+${pi.buildNumber}';

@ekuleshov Could you sahre the code with us where you set buildName+buildNumber? If the values from pubspec.yaml are the ones you want, you do not have to set this explicitly in options setup.

I would hope so, but uploaded artifacts wasn't linked with the app release. I've hacked it around in pubspec.yaml like this for now, but this shouldn't be required.

version: &ver 2.0.7+32
...
sentry:
  ...
  release: *ver
  ...

@buenaflor buenaflor moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK Aug 1, 2024
@denrase
Copy link
Collaborator

denrase commented Aug 5, 2024

Thx, i'll try to reproduce this. How exactly are you using _appVersion in relation to the Sentry SDK?

@buenaflor buenaflor moved this from Needs Investigation to Needs More Information in Mobile & Cross Platform SDK Aug 29, 2024
@buenaflor
Copy link
Contributor

let us know if this is still an issue

@buenaflor buenaflor closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Needs More Information to Done in Mobile & Cross Platform SDK Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants