Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentry web api #2489

Draft
wants to merge 30 commits into
base: feat/js-sdk-integration
Choose a base branch
from
Draft

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 12, 2024

Description

Allows type safe API access to underlying JS SDK

In this PR only init is implemented

💡 Motivation and Context

PR #2 of JS SDK Integration

💚 How did you test it?

Unit test, Integration Test, Manual Test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sending envelope

#skip-changelog

dependabot bot and others added 19 commits December 10, 2024 23:28
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.202.0 to 1.203.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb)
- [Commits](ruby/setup-ruby@a2bbe5b...2a18b06)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
…ive widget is not masked (#2375)

* feat: fail screenshot/replay creation when a potentially sensitive widget is not masked

* fix tests for web

* improve text

* warn instead of throwin an exception

* chore: changelog

* test: add debug/profile/release mode tests

* test assertion
* update

* update

* update

* run integration tests in ios again

* update test

* fix

* Update flutter_test.yml

* set runner to ubuntu for android integration test

* update test doc

* uncomment other tests

* update

* remove avd name

* update avd name

* Update flutter_test.yml

* Update flutter_test.yml

* Update .github/workflows/flutter_test.yml

* move expect after restoring flutter onError

* creation step without -no-snapshot-save

* update emulator options

* change cache key

* ignore deprecate

* update emulator

* remove emulator caching

---------

Co-authored-by: Ivan Dlugos <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 096f55d

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 32.69231% with 105 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (be08651) to head (096f55d).
Report is 27 commits behind head on feat/js-sdk-integration.

Files with missing lines Patch % Lines
flutter/lib/src/web/sentry_web.dart 0.00% 94 Missing ⚠️
dart/lib/src/platform_checker.dart 0.00% 7 Missing ⚠️
flutter/lib/src/screenshot/recorder.dart 71.42% 2 Missing ⚠️
.../lib/src/navigation/sentry_navigator_observer.dart 0.00% 1 Missing ⚠️
...ib/src/web/script_loader/sentry_script_loader.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/js-sdk-integration    #2489       +/-   ##
============================================================
+ Coverage                    70.98%   85.90%   +14.92%     
============================================================
  Files                           17      268      +251     
  Lines                          579     9522     +8943     
============================================================
+ Hits                           411     8180     +7769     
- Misses                         168     1342     +1174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor changed the title update feat: sentry web api Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart
  • flutter/lib/src/screenshot/widget_filter.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants