Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try/catch critical paths #2492

Draft
wants to merge 4 commits into
base: temp/8.11.1
Choose a base branch
from
Draft

Conversation

buenaflor
Copy link
Contributor

📜 Description

try/catch critical paths. If errors are thrown here it will lock the UI from processing either runApp or the page navigation

💡 Motivation and Context

Potentially fix #2491

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- try/catch critical paths ([#2492](https://github.com/getsentry/sentry-dart/pull/2492))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against e6aa9bf

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (617ae18) to head (e6aa9bf).

Files with missing lines Patch % Lines
dart/lib/src/sentry.dart 40.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           temp/8.11.1    #2492      +/-   ##
===============================================
- Coverage        86.85%   83.97%   -2.88%     
===============================================
  Files              260      180      -80     
  Lines             9242     6510    -2732     
===============================================
- Hits              8027     5467    -2560     
+ Misses            1215     1043     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/integrations/native_app_start_integration.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant