Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add new SDK overhead page for React Native #12065

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: Add new SDK overhead page for React Native #12065

wants to merge 5 commits into from
+49 −0

Conversation

kahest
Copy link
Member

@kahest kahest commented Dec 6, 2024 •
edited
Loading

DESCRIBE YOUR PR

Adds new "SDK Overhead" menu item + page below the "Mobile SDK Releases" item. Covers Errors etc. in more detail, links to existing product pages for Performance+Profiling+SR.

follow-up to #12063

fixes https://github.com/getsentry/projects/issues/454

Next steps/future work: see https://github.com/getsentry/projects/issues/169

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: no specific date, target is Dec 12
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 0:55am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 0:55am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 0:55am

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 174 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

@kahest kahest mentioned this pull request Dec 10, 2024
Merged
6 tasks
antonis
antonis approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Added a couple of comments/suggestions.

@kahest kahest requested a review from coolguyzone December 12, 2024 10:54
krystofwoldrich
krystofwoldrich approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about breadcrumbs impact mitigations, otherwise looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman

@coolguyzone coolguyzone Awaiting requested review from coolguyzone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kahest @antonis @krystofwoldrich