Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Instrument onResume in Activity transactions #2542

Open
romtsn opened this issue Feb 14, 2023 · 3 comments
Open

Auto-Instrument onResume in Activity transactions #2542

romtsn opened this issue Feb 14, 2023 · 3 comments
Labels
performance Performance API issues Platform: Android

Comments

@romtsn
Copy link
Member

romtsn commented Feb 14, 2023

Description

We could create spans for each of the callbacks to better surface the performance of each method if they involve some heavy computations (similar to how sentry-cocoa does it for viewDidLoad, viewDidAppear and so on).

Android API 29 and above have new callbacks in the AcitivtyLifecycleCallbacks class (onActivityPreCreated/onActivityPostCreated and friends), so we could utilize them when implementing it.

@markushi
Copy link
Member

Let's start small and use the existing API 29+ callbacks in the first iteration. And it could be a good chance to refactor our ActivityLifecycleIntegration.

@romtsn romtsn moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 8, 2023
@stefanosiano
Copy link
Member

Let's schedule it for the next quarter @kahest

@romtsn romtsn changed the title Auto-Instrument onCreate, onStart, onResume in Activity transactions Auto-Instrument onResume in Activity transactions Mar 6, 2024
@stefanosiano
Copy link
Member

let's discuss if we want to do it, as it could be "spammy", and if we want to do it for app start transactions or for all activities.
Based on the changes of warm start PR, all the logic would be inside our ActivityLifecycleIntegration, and it would be fairly easy to do (currently we have onCreate and onStart spans only for app start transactions)

@stefanosiano stefanosiano moved this from Backlog to Needs Discussion in Mobile & Cross Platform SDK Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance API issues Platform: Android
Projects
Status: Needs Discussion
Development

No branches or pull requests

5 participants