-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-Instrument onResume in Activity transactions #2542
Comments
Let's start small and use the existing API 29+ callbacks in the first iteration. And it could be a good chance to refactor our |
Let's schedule it for the next quarter @kahest |
let's discuss if we want to do it, as it could be "spammy", and if we want to do it for app start transactions or for all activities. |
Description
We could create spans for each of the callbacks to better surface the performance of each method if they involve some heavy computations (similar to how sentry-cocoa does it for viewDidLoad, viewDidAppear and so on).
Android API 29 and above have new callbacks in the AcitivtyLifecycleCallbacks class (
onActivityPreCreated
/onActivityPostCreated
and friends), so we could utilize them when implementing it.The text was updated successfully, but these errors were encountered: