Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add internal hybrid sdk api for fetching debug images that were referenced in the stacktrace #3925

Open
buenaflor opened this issue Nov 21, 2024 · 2 comments

Comments

@buenaflor
Copy link
Contributor

buenaflor commented Nov 21, 2024

Problem Statement

In Flutter when loading debug images on Android we fetch all (up to 82) but most of the time only libapp.so and libflutter.so is needed so it makes sense to only fetch images that are referenced in the stacktrace

Solution Brainstorm

Similar to cocoa: getsentry/team-mobile#158

Implementation how we access it in Cocoa on Flutter: https://github.com/getsentry/sentry-dart/blob/8549081071fd2bf85331d9988710b968ced8b2f1/flutter/ios/Classes/SentryFlutterPluginApple.swift#L280C1-L307C1

@buenaflor buenaflor changed the title Add internal hybrid sdk api for fetching debug images that were referenced in the stacktrace [Android] Add internal hybrid sdk api for fetching debug images that were referenced in the stacktrace Nov 21, 2024
@buenaflor
Copy link
Contributor Author

@markushi @romtsn I'd like to assign this issue to me if you're ok with it. anything specific I have to consider?

@romtsn
Copy link
Member

romtsn commented Nov 26, 2024

@buenaflor sure, take it all! I don't think there's anything specific (I don't know the native part that well though), from what I know the images list will be loaded lazily and cached in the native layer, and then you can add some methods to filter out only the necessary ones for you.

@buenaflor buenaflor self-assigned this Nov 26, 2024
@markushi markushi moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Nov 27, 2024
@markushi markushi moved this from In Progress to Backlog in Mobile & Cross Platform SDK Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants