Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ignored check performance #3967

Open
adinauer opened this issue Dec 6, 2024 · 0 comments
Open

Improve ignored check performance #3967

adinauer opened this issue Dec 6, 2024 · 0 comments
Assignees

Comments

@adinauer
Copy link
Member

adinauer commented Dec 6, 2024

Description

First create a benchmark to compare possible solutions.

Our options allow ignoring certain things like transactions by name, spans by origin or checkins by slug. We are compiling the pattern each time which we could do only once at the start / when setting the option.

Ideas for improving:

  • Iterate and only do equals comparison for all in list first, then iterate again and try to match via regex
  • Compile pattern when setting the option, storing something like FilterString in options that holds both the String and the compiled pattern
  • A decision cache for span origins only (as those should be low cardinality). We should not do this for transaction names or checkin slugs. Maybe a simple map where we store a bool for each origin we check can improve performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

2 participants