Handle App Start Continuous Profiling v8 (p4) #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on config updated SentryAppStartProfilingOptions with isContinuousProfilingEnabled flag updated SentryOptions with isContinuousProfilingEnabled() method
stefanosiano
changed the base branch from
main
to
feat/continuous-profiling-part3
7 tasks
|
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
romtsn
reviewed
Nov 11, 2024
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Nov 11, 2024
| @@ -98,6 +99,11 @@ public void shutdown() { | |||
| if (appStartProfiler != null) { | |||
| appStartProfiler.close(); | |||
| } | |||
| final @Nullable IContinuousProfiler appStartContinuousProfiler = | |||
There was a problem hiding this comment.
as I understood there could be only one profiler at a time (cont. or tx-based), right? Just got an idea we could have a general IProfiler interface (that would have all the methods that IContinuousProfiler currently has), and then it'd have a sub-interface ITransactionProfiler with the tx-specific methods.
This way you could only manage one instance of IProfiler everywhere (like here) and it would be more readable I guess.
There was a problem hiding this comment.
you're probably right on this, but in the long term we will deprecate and optionally remove the transaction profiler.
I think the extraction of the AndroidProfiler is enough for now.
But we can refactor it if you have a strong preference
romtsn
reviewed
Nov 11, 2024
romtsn
approved these changes
Nov 11, 2024
…of AndroidOptionsInitializer
…rofiling-part4 # Conflicts: # sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java # sentry-android-core/src/main/java/io/sentry/android/core/SentryPerformanceProvider.java # sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java # sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt # sentry/src/main/java/io/sentry/SentryOptions.java
Performance metrics 🚀
|
* AndroidContinuousProfiler now retrieve the scopes on start() * removed profilesSampleRate from sample app to enable continuous profiling * added Sentry.startProfiler and Sentry.stopProfiler APIs
stefanosiano
merged commit c0a7fd1
into
feat/continuous-profiling-part3
24 of 25 checks passed
stefanosiano
added a commit
that referenced
this pull request
Nov 14, 2024
* added profile context to SentryTracer * removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless * added continuous profiler to SentryOptions * added DefaultTransactionPerformanceCollector to AndroidContinuousProfiler * updated DefaultTransactionPerformanceCollector to work with string ids other than transactions * fixed ProfileChunk measurements being modifiable from other code * added thread id and name to SpanContext.data * added profiler_id to span data * close continuous profiler on scopes close * renamed TransactionPerformanceCollector to CompositePerformanceCollector * added SpanContext.data ser/deser Handle App Start Continuous Profiling v8 (p4) (#3730) * create app start continuous profiler instead of transaction profiler, based on config * updated SentryAppStartProfilingOptions with isContinuousProfilingEnabled flag * updated SentryOptions with isContinuousProfilingEnabled() method * cut profiler setup out in a specific function to improve readability of AndroidOptionsInitializer Add new APIs for Continuous Profiling v8 (p5) (#3844) * AndroidContinuousProfiler now retrieve the scopes on start() * removed profilesSampleRate from sample app to enable continuous profiling * added Sentry.startProfiler and Sentry.stopProfiler APIs
stefanosiano
added a commit
that referenced
this pull request
Nov 14, 2024
* added profile_chunk envelope create * added IHub.captureProfileChunk and ISentryClient.captureProfileChunk * added profilerId and chunkId reset logic to AndroidContinuousProfiler * added absolute timestamps to ProfileMeasurementValue * added ProfileContext to Contexts * removed timestampMillis from MemoryCollectionData and CpuCollectionData, now it uses timestamp.nanotime() to achieve same result * continuous profiler doesn't stop anymore when an error occurs, but continue scheduling restart Instantiate continuous profiling v8 (p3) (#3725) * added profile context to SentryTracer * removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless * added continuous profiler to SentryOptions * added DefaultTransactionPerformanceCollector to AndroidContinuousProfiler * updated DefaultTransactionPerformanceCollector to work with string ids other than transactions * fixed ProfileChunk measurements being modifiable from other code * added thread id and name to SpanContext.data * added profiler_id to span data * close continuous profiler on scopes close * renamed TransactionPerformanceCollector to CompositePerformanceCollector * added SpanContext.data ser/deser Handle App Start Continuous Profiling v8 (p4) (#3730) * create app start continuous profiler instead of transaction profiler, based on config * updated SentryAppStartProfilingOptions with isContinuousProfilingEnabled flag * updated SentryOptions with isContinuousProfilingEnabled() method * cut profiler setup out in a specific function to improve readability of AndroidOptionsInitializer Add new APIs for Continuous Profiling v8 (p5) (#3844) * AndroidContinuousProfiler now retrieve the scopes on start() * removed profilesSampleRate from sample app to enable continuous profiling * added Sentry.startProfiler and Sentry.stopProfiler APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
create app start continuous profiler instead of transaction profiler, based on config
updated SentryAppStartProfilingOptions with isContinuousProfilingEnabled flag
updated SentryOptions with isContinuousProfilingEnabled() method
#skip-changelog
💡 Motivation and Context
Handle App Start Continuous Profiler
Part 4 of #3710
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps