Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OtelSentrySpanProcessorTest #3877

Draft
wants to merge 8 commits into
base: 8.x.x
Choose a base branch
from
Draft

OtelSentrySpanProcessorTest #3877

wants to merge 8 commits into from

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Nov 12, 2024

📜 Description

SematicAttributes.HTTP_METHOD as fallback if HttpAttributes.HTTP_REQUEST_METHOD is null
Add OtelSentrySpanProcessorTest

💡 Motivation and Context

Initial Unit Test for OtelSentrySpanProcessor
Support both SematicAttributes.HTTP_METHOD and HttpAttributes.HTTP_REQUEST_METHOD

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- [POTEL-57] Support HTTP_METHOD and HTTP_REQUEST_METHOD for Otel Spans ([#3877](https://github.com/getsentry/sentry-java/pull/3877))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 719dfa2

@lbloder lbloder changed the title [POTEL-57] Support HTTP_METHOD and HTTP_REQUEST_METHOD for Otel Spans OtelSentrySpanProcessorTest Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants