Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle, AGP and Kotlin versions #3936

Open
wants to merge 3 commits into
base: 8.x.x
Choose a base branch
from

Conversation

markushi
Copy link
Member

📜 Description

Supersedes #3839

💡 Motivation and Context

New features, faster builds.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.11 ms 478.15 ms 46.04 ms
Size 1.58 MiB 2.20 MiB 635.52 KiB

Previous results on branch: chore/bump-gradle-agp-kotlin-8.x.x

Startup times

Revision Plain With Sentry Diff
b956ed4 394.35 ms 431.90 ms 37.55 ms
75ebeda 418.66 ms 473.06 ms 54.40 ms

App size

Revision Plain With Sentry Diff
b956ed4 1.58 MiB 2.20 MiB 635.41 KiB
75ebeda 1.58 MiB 2.20 MiB 635.41 KiB

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:tools="http://schemas.android.com/tools">

<!-- Compose requires min SDK 21, but our min SDK is set to 19 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop this thing now, right?

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check the comments from #3839 around uppercase/lowercase and that weird extension function?

@@ -15,6 +15,10 @@

## 8.0.0-rc.1

### Breaking Changes

- The Kotlin Language version is now set to 1.6 ([#3936](https://github.com/getsentry/sentry-java/pull/3936))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 8.0.0.
    Consider moving the entry to the ## Unreleased section, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants