Fix incoming defer sampling decision sentry-trace header #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
adinauer
commented
Nov 29, 2024
...y-samples-spring-boot-opentelemetry/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Outdated
Show resolved
Hide resolved
adinauer
commented
Nov 29, 2024
| samplingDecision = new TracesSamplingDecision(sampled, sampleRate); | ||
| } else { | ||
| samplingDecision = new TracesSamplingDecision(sampled); | ||
| if (parentSampled != null) { |
There was a problem hiding this comment.
now uses null sampling decision instead of false for incoming sentry-trace header with deferred sampling decision. This causes sentry sampler to make a decision instead of assuming false from parent should be copied.
adinauer
commented
Nov 29, 2024
...-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentrySpanRestClientCustomizerTest.kt
Show resolved
Hide resolved
adinauer
commented
Nov 29, 2024
...-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentrySpanRestClientCustomizerTest.kt
Show resolved
Hide resolved
adinauer
commented
Nov 29, 2024
adinauer
commented
Nov 29, 2024
...y-samples-spring-boot-opentelemetry/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Show resolved
Hide resolved
adinauer
commented
Nov 29, 2024
| @@ -44,4 +44,70 @@ class PersonSystemTest { | |||
| testHelper.doesTransactionContainSpanWithOp(transaction, "spanCreatedThroughSentryApi") | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
TODO use @BeforeTest instead of @Before as it looks like it's not resetting between tests in the same test class.
There was a problem hiding this comment.
TODO copy this test over to other samples (e.g. jakarta version of this)
There was a problem hiding this comment.
Let's do this in a follow up PR
Performance metrics 🚀
|
An error occurred while trying to automatically change base from
feat/bump-spring-boot-3-4
to
8.x.x
December 2, 2024 14:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix incoming defer sampling decision sentry-trace header
And forward
isSampledfrom propagation context to sentry-trace header when not building tracing info from a span.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps