Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - e2e test for distributed tracing #3948

Draft
wants to merge 11 commits into
base: 8.x.x
Choose a base branch
from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 2, 2024

📜 Description

POC - e2e test for distributed tracing

  • Test expects the http.client span to be present but it's missing when running the e2e tests.
  • We tested manually and it's there

TODO investigate

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POC - e2e test for distributed tracing ([#3948](https://github.com/getsentry/sentry-java/pull/3948))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 713e7c5

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 429.98 ms 451.08 ms 21.10 ms
Size 1.65 MiB 2.31 MiB 676.07 KiB

Base automatically changed from feat/build-propagation-context-from-sampling-decision to 8.x.x December 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant