Merge pull request #16265 from getsentry/prepare-release/9.18.0

meta(changelog): Update changelog for 9.18.0

Author: andreiborza

.github/workflows/build.yml

@@ -475,7 +475,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [18, 20, 22]
+        node: [18, 20, 22, '^24.0.1']
     steps:
       - name: Check out base commit (${{ github.event.pull_request.base.sha }})
         uses: actions/checkout@v4
@@ -713,12 +713,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['18.20.5', 20, 22]
+        node: ['18.20.5', 20, 22, 24]
         typescript:
           - false
         include:
           # Only check typescript for latest version (to streamline CI)
-          - node: 22
+          - node: 24
             typescript: '3.8'
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
@@ -760,7 +760,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [18, 20, 22]
+        node: [18, 20, 22, 24]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4

.size-limit.js

@@ -54,7 +54,7 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
     gzip: true,
-    limit: '70 KB',
+    limit: '70.1 KB',
     modifyWebpackConfig: function (config) {
       const webpack = require('webpack');
       const TerserPlugin = require('terser-webpack-plugin');

CHANGELOG.md

@@ -10,6 +10,27 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 9.18.0
+
+### Important changes
+
+- **feat: Support Node 24 ([#16236](https://github.com/getsentry/sentry-javascript/pull/16236))**
+
+We now also publish profiling binaries for Node 24.
+
+### Other changes
+
+- deps(node): Bump `import-in-the-middle` to `1.13.1` ([#16260](https://github.com/getsentry/sentry-javascript/pull/16260))
+- feat: Export `consoleLoggingIntegration` from vercel edge sdk ([#16228](https://github.com/getsentry/sentry-javascript/pull/16228))
+- feat(cloudflare): Add support for email, queue, and tail handler ([#16233](https://github.com/getsentry/sentry-javascript/pull/16233))
+- feat(cloudflare): Improve http span data ([#16232](https://github.com/getsentry/sentry-javascript/pull/16232))
+- feat(nextjs): Add more attributes for generation functions ([#16214](https://github.com/getsentry/sentry-javascript/pull/16214))
+- feat(opentelemetry): Widen peer dependencies to support Otel v2 ([#16246](https://github.com/getsentry/sentry-javascript/pull/16246))
+- fix(core): Gracefully handle invalid baggage entries ([#16257](https://github.com/getsentry/sentry-javascript/pull/16257))
+- fix(node): Ensure traces are propagated without spans in Node 22+ ([#16221](https://github.com/getsentry/sentry-javascript/pull/16221))
+- fix(node): Use sentry forked `@fastify/otel` dependency with pinned Otel v1 deps ([#16256](https://github.com/getsentry/sentry-javascript/pull/16256))
+- fix(remix): Remove vendored types ([#16218](https://github.com/getsentry/sentry-javascript/pull/16218))
+
 ## 9.17.0
 
 - feat(node): Migrate to `@fastify/otel` ([#15542](https://github.com/getsentry/sentry-javascript/pull/15542))

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/server-components.test.ts

@@ -80,8 +80,8 @@ test('Should set a "not_found" status on a server component span when notFound()
       op: 'function.nextjs',
       status: 'not_found',
       data: expect.objectContaining({
-        'sentry.nextjs.function.type': 'Page',
-        'sentry.nextjs.function.route': '/server-component/not-found',
+        'sentry.nextjs.ssr.function.type': 'Page',
+        'sentry.nextjs.ssr.function.route': '/server-component/not-found',
       }),
     }),
   );
@@ -112,8 +112,8 @@ test('Should capture an error and transaction for a app router page', async ({ p
       op: 'function.nextjs',
       status: 'internal_error',
       data: expect.objectContaining({
-        'sentry.nextjs.function.type': 'Page',
-        'sentry.nextjs.function.route': '/server-component/faulty',
+        'sentry.nextjs.ssr.function.type': 'Page',
+        'sentry.nextjs.ssr.function.route': '/server-component/faulty',
       }),
     }),
   );

dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

@@ -35,11 +35,7 @@
     "@sentry/opentelemetry": "latest || *",
     "@sentry/react": "latest || *",
     "@sentry-internal/replay": "latest || *",
-    "@sentry/vercel-edge": "latest || *",
-    "import-in-the-middle": "1.12.0"
-  },
-  "overrides": {
-    "import-in-the-middle": "1.12.0"
+    "@sentry/vercel-edge": "latest || *"
   },
   "volta": {
     "extends": "../../package.json"

dev-packages/node-integration-tests/.eslintrc.js

@@ -18,6 +18,9 @@ module.exports = {
         sourceType: 'module',
         ecmaVersion: 'latest',
       },
+      globals: {
+        fetch: 'readonly',
+      },
       rules: {
         '@typescript-eslint/typedef': 'off',
         // Explicitly allow ts-ignore with description for Node integration tests

dev-packages/node-integration-tests/suites/esm/warn-esm/test.ts

@@ -5,8 +5,7 @@ afterAll(() => {
   cleanupChildProcesses();
 });
 
-const esmWarning =
-  '[Sentry] You are using Node.js in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.';
+const esmWarning = `[Sentry] You are using Node.js v${process.versions.node} in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version.`;
 
 test("warns if using ESM on Node.js versions that don't support `register()`", async () => {
   const nodeMajorVersion = Number(process.versions.node.split('.')[0]);

dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/instrument.mjs

@@ -0,0 +1,18 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracePropagationTargets: [/\/v0/, 'v1'],
+  integrations: [],
+  transport: loggingTransport,
+  tracesSampleRate: 0.0,
+  // Ensure this gets a correct hint
+  beforeBreadcrumb(breadcrumb, hint) {
+    breadcrumb.data = breadcrumb.data || {};
+    const req = hint?.request;
+    breadcrumb.data.ADDED_PATH = req?.path;
+    return breadcrumb;
+  },
+});

dev-packages/node-integration-tests/suites/tracing/requests/fetch-sampled-no-active-span/scenario.ts renamed to dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/scenario.mjs

@@ -1,16 +1,8 @@
 import * as Sentry from '@sentry/node';
-import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
-Sentry.init({
-  dsn: 'https://[email protected]/1337',
-  release: '1.0',
-  tracePropagationTargets: [/\/v0/, 'v1'],
-  tracesSampleRate: 1.0,
-  integrations: [],
-  transport: loggingTransport,
-});
+async function run() {
+  Sentry.addBreadcrumb({ message: 'manual breadcrumb' });
 
-async function run(): Promise<void> {
   await fetch(`${process.env.SERVER_URL}/api/v0`).then(res => res.text());
   await fetch(`${process.env.SERVER_URL}/api/v1`).then(res => res.text());
   await fetch(`${process.env.SERVER_URL}/api/v2`).then(res => res.text());
@@ -19,5 +11,4 @@ async function run(): Promise<void> {
   Sentry.captureException(new Error('foo'));
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/scenario.ts

@@ -1,78 +1,80 @@
-import { describe, expect, test } from 'vitest';
-import { createRunner } from '../../../../utils/runner';
+import { describe, expect } from 'vitest';
+import { createEsmAndCjsTests } from '../../../../utils/runner';
 import { createTestServer } from '../../../../utils/server';
 
 describe('outgoing fetch', () => {
-  test('outgoing fetch requests create breadcrumbs', async () => {
-    const [SERVER_URL, closeTestServer] = await createTestServer().start();
+  createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
+    test('outgoing fetch requests create breadcrumbs xxx', async () => {
+      const [SERVER_URL, closeTestServer] = await createTestServer().start();
 
-    await createRunner(__dirname, 'scenario.ts')
-      .withEnv({ SERVER_URL })
-      .ensureNoErrorOutput()
-      .expect({
-        event: {
-          breadcrumbs: [
-            {
-              message: 'manual breadcrumb',
-              timestamp: expect.any(Number),
-            },
-            {
-              category: 'http',
-              data: {
-                'http.method': 'GET',
-                url: `${SERVER_URL}/api/v0`,
-                status_code: 404,
-                ADDED_PATH: '/api/v0',
+      await createRunner()
+        .withEnv({ SERVER_URL })
+        .expect({
+          event: {
+            breadcrumbs: [
+              {
+                message: 'manual breadcrumb',
+                timestamp: expect.any(Number),
               },
-              timestamp: expect.any(Number),
-              type: 'http',
-            },
-            {
-              category: 'http',
-              data: {
-                'http.method': 'GET',
-                url: `${SERVER_URL}/api/v1`,
-                status_code: 404,
-                ADDED_PATH: '/api/v1',
+              {
+                category: 'http',
+                data: {
+                  'http.method': 'GET',
+                  url: `${SERVER_URL}/api/v0`,
+                  status_code: 404,
+                  ADDED_PATH: '/api/v0',
+                },
+                timestamp: expect.any(Number),
+                type: 'http',
               },
-              timestamp: expect.any(Number),
-              type: 'http',
-            },
-            {
-              category: 'http',
-              data: {
-                'http.method': 'GET',
-                url: `${SERVER_URL}/api/v2`,
-                status_code: 404,
-                ADDED_PATH: '/api/v2',
+              {
+                category: 'http',
+                data: {
+                  'http.method': 'GET',
+                  url: `${SERVER_URL}/api/v1`,
+                  status_code: 404,
+                  ADDED_PATH: '/api/v1',
+                },
+                timestamp: expect.any(Number),
+                type: 'http',
               },
-              timestamp: expect.any(Number),
-              type: 'http',
-            },
-            {
-              category: 'http',
-              data: {
-                'http.method': 'GET',
-                url: `${SERVER_URL}/api/v3`,
-                status_code: 404,
-                ADDED_PATH: '/api/v3',
+              {
+                category: 'http',
+                data: {
+                  'http.method': 'GET',
+                  url: `${SERVER_URL}/api/v2`,
+                  status_code: 404,
+                  ADDED_PATH: '/api/v2',
+                },
+                timestamp: expect.any(Number),
+                type: 'http',
               },
-              timestamp: expect.any(Number),
-              type: 'http',
-            },
-          ],
-          exception: {
-            values: [
               {
-                type: 'Error',
-                value: 'foo',
+                category: 'http',
+                data: {
+                  'http.method': 'GET',
+                  url: `${SERVER_URL}/api/v3`,
+                  status_code: 404,
+                  ADDED_PATH: '/api/v3',
+                },
+                timestamp: expect.any(Number),
+                type: 'http',
               },
             ],
+            exception: {
+              values: [
+                {
+                  type: 'Error',
+                  value: 'foo',
+                },
+              ],
+            },
           },
-        },
-      })
-      .start()
-      .completed();
-    closeTestServer();
+        })
+        .start()
+        .completed();
+
+      closeTestServer();
+    });
   });
 });

dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/test.ts

@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  release: '1.0',
+  tracePropagationTargets: [/\/v0/, 'v1'],
+  integrations: [Sentry.nativeNodeFetchIntegration({ spans: false })],
+  transport: loggingTransport,
+});

dev-packages/node-integration-tests/suites/tracing/requests/fetch-no-tracing-no-spans/instrument.mjs

@@ -0,0 +1,12 @@
+import * as Sentry from '@sentry/node';
+
+async function run() {
+  await fetch(`${process.env.SERVER_URL}/api/v0`).then(res => res.text());
+  await fetch(`${process.env.SERVER_URL}/api/v1`).then(res => res.text());
+  await fetch(`${process.env.SERVER_URL}/api/v2`).then(res => res.text());
+  await fetch(`${process.env.SERVER_URL}/api/v3`).then(res => res.text());
+
+  Sentry.captureException(new Error('foo'));
+}
+
+run();