Skip to content

Commit 6bed42f

Browse files
benvinegarbenvinegar
committed
Merge pull request #575 from getsentry/3.0.4
3.0.4
2 parents 0784c3c + e9bea01 commit 6bed42f

24 files changed

+44
-38
lines changed

‎CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 3.0.4
4+
* BUGFIX: Navigation breadcrumbs now include query strings and document fragment (#). See: https://github.com/getsentry/raven-js/issues/573
5+
* BUGFIX: Remove errant `throw` call in _makeRequest affecting some Raven configs. See: https://github.com/getsentry/raven-js/pull/572
6+
37
## 3.0.3
48
* BUGFIX: Fix pushState instrumentation breaking on non-string URL args. See: https://github.com/getsentry/raven-js/issues/569
59

‎bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "raven-js",
3-
"version": "3.0.3",
3+
"version": "3.0.4",
44
"dependencies": {},
55
"main": "dist/raven.js",
66
"ignore": [

‎dist/plugins/angular.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! Raven.js 3.0.3 (3738576) | github.com/getsentry/raven-js */
1+
/*! Raven.js 3.0.4 (0784c3c) | github.com/getsentry/raven-js */
22

33
/*
44
* Includes TraceKit

‎dist/plugins/angular.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/plugins/console.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! Raven.js 3.0.3 (3738576) | github.com/getsentry/raven-js */
1+
/*! Raven.js 3.0.4 (0784c3c) | github.com/getsentry/raven-js */
22

33
/*
44
* Includes TraceKit

‎dist/plugins/console.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/plugins/ember.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! Raven.js 3.0.3 (3738576) | github.com/getsentry/raven-js */
1+
/*! Raven.js 3.0.4 (0784c3c) | github.com/getsentry/raven-js */
22

33
/*
44
* Includes TraceKit

‎dist/plugins/ember.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/plugins/require.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! Raven.js 3.0.3 (3738576) | github.com/getsentry/raven-js */
1+
/*! Raven.js 3.0.4 (0784c3c) | github.com/getsentry/raven-js */
22

33
/*
44
* Includes TraceKit

‎dist/plugins/require.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/raven.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! Raven.js 3.0.3 (3738576) | github.com/getsentry/raven-js */
1+
/*! Raven.js 3.0.4 (0784c3c) | github.com/getsentry/raven-js */
22

33
/*
44
* Includes TraceKit
@@ -150,7 +150,7 @@ Raven.prototype = {
150150
// webpack (using a build step causes webpack #1617). Grunt verifies that
151151
// this value matches package.json during build.
152152
// See: https://github.com/getsentry/raven-js/issues/465
153-
VERSION: '3.0.3',
153+
VERSION: '3.0.4',
154154

155155
debug: false,
156156

@@ -778,9 +778,9 @@ Raven.prototype = {
778778
// Use only the path component of the URL if the URL matches the current
779779
// document (almost all the time when using pushState)
780780
if (parsedLoc.protocol === parsedTo.protocol && parsedLoc.host === parsedTo.host)
781-
to = parsedTo.path;
781+
to = parsedTo.relative;
782782
if (parsedLoc.protocol === parsedFrom.protocol && parsedLoc.host === parsedFrom.host)
783-
from = parsedFrom.path;
783+
from = parsedFrom.relative;
784784

785785
this.captureBreadcrumb({
786786
category: 'navigation',
@@ -1357,9 +1357,6 @@ Raven.prototype = {
13571357
_makeRequest: function(opts) {
13581358
var request = new XMLHttpRequest();
13591359

1360-
if (request.send.toString() === 'function send() { [native code] }') {
1361-
throw new Error('shouldnt get here');
1362-
}
13631360
// if browser doesn't support CORS (e.g. IE7), we are out of luck
13641361
var hasCORS =
13651362
'withCredentials' in request ||
@@ -1581,10 +1578,15 @@ function urlencode(o) {
15811578
function parseUrl(url) {
15821579
var match = url.match(/^(([^:\/?#]+):)?(\/\/([^\/?#]*))?([^?#]*)(\?([^#]*))?(#(.*))?$/);
15831580
if (!match) return {};
1581+
1582+
// coerce to undefined values to empty string so we don't get 'undefined'
1583+
var query = match[6] || '';
1584+
var fragment = match[8] || '';
15841585
return {
15851586
protocol: match[2],
15861587
host: match[4],
1587-
path: match[5]
1588+
path: match[5],
1589+
relative: match[5] + query + fragment // everything minus origin
15881590
};
15891591
}
15901592
function uuid4() {

‎dist/raven.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/raven.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/sri.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"@dist/raven.js": {
33
"hashes": {
4-
"sha256": "QjY8F5qPj7FAZ9zHS5G4O8047voJ/Y5cx92SRno24uc=",
5-
"sha512": "1QM0Ou9Yp+QZ86ZZgqBFLgXFlwi3Igi/Yte1VvgsM9nQnapbyyhd5NdkMBrt73lFCcMXcMSQwEJSRKf4VKRd8A=="
4+
"sha256": "BhyUFN42x1X3lpmcdqb9FeEEDX120bZD5Tviil7eN+U=",
5+
"sha512": "Dcum5QDTkYiE2J8Ds/8UcgOv18moIIbEg8f/2aYWcnl7MKx/015DAaqM0KmRI/bAL1r1l3r5E89H9eKfDPyBtg=="
66
},
77
"type": null,
8-
"integrity": "sha256-QjY8F5qPj7FAZ9zHS5G4O8047voJ/Y5cx92SRno24uc= sha512-1QM0Ou9Yp+QZ86ZZgqBFLgXFlwi3Igi/Yte1VvgsM9nQnapbyyhd5NdkMBrt73lFCcMXcMSQwEJSRKf4VKRd8A==",
8+
"integrity": "sha256-BhyUFN42x1X3lpmcdqb9FeEEDX120bZD5Tviil7eN+U= sha512-Dcum5QDTkYiE2J8Ds/8UcgOv18moIIbEg8f/2aYWcnl7MKx/015DAaqM0KmRI/bAL1r1l3r5E89H9eKfDPyBtg==",
99
"path": "dist/raven.js"
1010
},
1111
"@dist/raven.min.js": {
1212
"hashes": {
13-
"sha256": "RquNiADCm9QcEuQSH0dRBOBv/KEzrceIvP0bWENzzrU=",
14-
"sha512": "Utvtpxczqgj+B0P8w771re39iFYld8tRvWzez6dU8vVjmFwQFb8j3o7tFPgkg4qXw4xgZNLlFLcKReA0U3wDww=="
13+
"sha256": "g9X2G0d7lq0Uv4i8OTMimZZ4V1WbnbDo6krrRaixbGI=",
14+
"sha512": "sTnnzoocXXoQsv0lJQHeLHyDmU9RL9jvzOzyCRuWByF+XlELresM7b5exk1vBu9E8B1o/kxA99ZcgkOeYBw8SQ=="
1515
},
1616
"type": null,
17-
"integrity": "sha256-RquNiADCm9QcEuQSH0dRBOBv/KEzrceIvP0bWENzzrU= sha512-Utvtpxczqgj+B0P8w771re39iFYld8tRvWzez6dU8vVjmFwQFb8j3o7tFPgkg4qXw4xgZNLlFLcKReA0U3wDww==",
17+
"integrity": "sha256-g9X2G0d7lq0Uv4i8OTMimZZ4V1WbnbDo6krrRaixbGI= sha512-sTnnzoocXXoQsv0lJQHeLHyDmU9RL9jvzOzyCRuWByF+XlELresM7b5exk1vBu9E8B1o/kxA99ZcgkOeYBw8SQ==",
1818
"path": "dist/raven.min.js"
1919
}
2020
}

‎docs/config.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ Putting it all together
237237
<body>
238238
...
239239
<script src="jquery.min.js"></script>
240-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
240+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
241241
<script>
242242
Raven.config('___PUBLIC_DSN___', {
243243
logger: 'my-logger',

‎docs/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ scripts. For all details see :doc:`install`.
2626

2727
.. sourcecode:: html
2828

29-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
29+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
3030

3131

3232
Configuring the Client

‎docs/install.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ So for example:
99
.. sourcecode:: html
1010

1111
<script src="jquery.js"></script>
12-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
12+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
1313
<script>Raven.config('___PUBLIC_DSN___').install();</script>
1414
<script src="app.js"></script>
1515

@@ -28,7 +28,7 @@ Our CDN distributes builds with and without :doc:`integrations <integrations/ind
2828

2929
.. sourcecode:: html
3030

31-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
31+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
3232

3333
This version does not include any plugins. See `ravenjs.com
3434
<http://ravenjs.com/>`_ for more information about plugins and getting

‎docs/integrations/angular.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Example:
2727
.. sourcecode:: html
2828

2929
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
30-
<script src="https://cdn.ravenjs.com/3.0.3/angular/raven.min.js"></script>
30+
<script src="https://cdn.ravenjs.com/3.0.4/angular/raven.min.js"></script>
3131
<script>Raven.config('___PUBLIC_DSN___').install();</script>
3232

3333
Note that this CDN build auto-initializes the Angular plugin.

‎docs/integrations/backbone.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
99

1010
.. sourcecode:: html
1111

12-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
12+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
1313

1414
Configuring the Client
1515
----------------------

‎docs/integrations/ember.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Example:
2323
.. sourcecode:: html
2424

2525
<script src="http://builds.emberjs.com/tags/v2.3.1/ember.prod.js"></script>
26-
<script src="https://cdn.ravenjs.com/3.0.3/ember/raven.min.js"></script>
26+
<script src="https://cdn.ravenjs.com/3.0.4/ember/raven.min.js"></script>
2727
<script>Raven.config('___PUBLIC_DSN___').install();</script>
2828

2929
Note that this CDN build auto-initializes the Ember plugin.

‎docs/integrations/react.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
99

1010
.. sourcecode:: html
1111

12-
<script src="https://cdn.ravenjs.com/3.0.3/raven.min.js"></script>
12+
<script src="https://cdn.ravenjs.com/3.0.4/raven.min.js"></script>
1313

1414
Configuring the Client
1515
----------------------

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "raven-js",
3-
"version": "3.0.3",
3+
"version": "3.0.4",
44
"license": "BSD-2-Clause",
55
"homepage": "https://getsentry.com",
66
"scripts": {

‎src/raven.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Raven.prototype = {
8686
// webpack (using a build step causes webpack #1617). Grunt verifies that
8787
// this value matches package.json during build.
8888
// See: https://github.com/getsentry/raven-js/issues/465
89-
VERSION: '3.0.3',
89+
VERSION: '3.0.4',
9090

9191
debug: false,
9292

‎test/raven.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,7 @@ describe('globals', function() {
10741074
extra: {'session:duration': 100},
10751075
});
10761076
assert.deepEqual(opts.auth, {
1077-
sentry_client: 'raven-js/3.0.3',
1077+
sentry_client: 'raven-js/3.0.4',
10781078
sentry_key: 'abc',
10791079
sentry_version: '7'
10801080
});
@@ -1121,7 +1121,7 @@ describe('globals', function() {
11211121
extra: {'session:duration': 100},
11221122
});
11231123
assert.deepEqual(opts.auth, {
1124-
sentry_client: 'raven-js/3.0.3',
1124+
sentry_client: 'raven-js/3.0.4',
11251125
sentry_key: 'abc',
11261126
sentry_secret: 'def',
11271127
sentry_version: '7'

0 commit comments

Comments
 (0)