Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Feedback Beta: Localization #10209

Closed
ds-clearago opened this issue Jan 16, 2024 · 8 comments
Closed

User Feedback Beta: Localization #10209

ds-clearago opened this issue Jan 16, 2024 · 8 comments

Comments

@ds-clearago
Copy link

Problem Statement

Is a locale setting coming to the configuration options of the widget?
We can use https://www.i18next.com/ for internationalization (i18n), localization (l10n) and translation for now, but obviously it would be easier if standard labels for various languages would already be there out of the box

⚠️ Furthermore, it seems that the (required) from Description (required) isn't exposed and therefore not translatable atm...


In https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#crash-report-modal
does lang [automatic] – override for Sentry’s language code already handle this?


This is an almost verbatim copy of my getsentry/sentry#60134 (comment) reposted here in response to @billyvg's comment

Solution Brainstorm

de-DE for https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#text-customization could be:

key description default (ENGLISH) new English GERMAN
buttonLabel The label of the injected button. Report a Bug Fehler melden
submitButtonLabel The label of the submit button used in the feedback form. Send Bug Report Fehlermeldung absenden
cancelButtonLabel The label of the cancel button used in the feedback form. Cancel Abbrechen
formTitle The title at the top of the feedback form. Report a Bug Fehler melden
nameLabel The label of the name input field. Name Name
namePlaceholder The placeholder for the name input field. Your Name Ihr Name
emailLabel The label of the email input field. Email E-Mail
emailPlaceholder The placeholder for the email input field. [email protected] [email protected]
messageLabel The label for the feedback description input field. Description Beschreibung
messagePlaceholder The placeholder for the feedback description input field. What's the bug? What did you expect? What's the bug? What did you expect? What steps led to it? Was haben Sie erwartet und was ist stattdessen passiert? Was führte dazu?
successMessageText The message to be displayed after a succesful feedback submission. Thank you for your report! Vielen Dank für Ihre Fehlermeldung. Unsere Entwickler kümmern sich alsbald darum.
⚠️ requiredLabel The string appended to input labels of required fields. (required) (Pflichtfeld)

de-DE for In https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#crash-report-modal could be:

Param Default DE
⚠️ lang [automatic] – override for Sentry’s language code  
title It looks like we’re having issues. Es sieht aus als hätten wir Probleme.
subtitle Our team has been notified. Unser Team wurde benachrichtigt.
subtitle2 If you’d like to help, tell us what happened below. – not visible on small screen resolutions Wenn Sie helfen wollen, beschreiben Sie unten was passiert ist.
labelName Name Name
labelEmail Email E-Mail
labelComments What happened? Was ist passiert?
labelClose Close Schließen
labelSubmit Submit Absenden
errorGeneric An unknown error occurred while submitting your report. Please try again. Ein unbekannter Fehler ist während dem Absenden Ihres Fehlerberichts aufgetreten. Versuchen Sie es noch einmal.
errorFormEntry Some fields were invalid. Please correct the errors and try again. Einige Felder sind ungültig. Bitte korrigieren Sie die Fehler und versuchen Sie es noch einmal.
successMessage Your feedback has been sent. Thank you! Ihr Feedback wurde abgesendet. Vielen Dank!
@shaedrich
Copy link

Here are some minor findings from my end:

Report a Bug | Fehler melden

I'm not sure, why there is an explicit "a" in the English version, but if it is intentional, shouldn't there be an "einen" before "Fehler" in the German translation?

What's the bug? What did you expect? What steps led to it? | Was haben Sie erwartet und was ist stattdessen passiert? Was führte dazu?

Is there a reason, the German version concatenates the two sentences into one, whereas the English one keeps them separate?

Thank you for your report! | Vielen Dank für Ihre Fehlermeldung. Unsere Entwickler kümmern sich alsbald darum.

It's nice, that German developers take care of the report immediately (not a very state of the art way of saying that in German btw)—but do English developers do that as well?

An unknown error occurred while submitting your report. Please try again. | Ein unbekannter Fehler ist während dem Absenden Ihres Fehlerberichts aufgetreten. Versuchen Sie es noch einmal.

I know, Germans are not really known for being polite, but if they want to adhere to the English version, they have to bite the bullet and say "Bitte" as nice as they can 😉

@cleptric
Copy link
Member

I know, Germans are not really known for being polite

I do not support this statement whatsoever!

In any case, while I'm not invested in this, I recommend not including any translations out of the box. This is primarily a bundle size concern, and secondly, as we already see in this issue, people might want to translate certain things differently.

@billyvg
Copy link
Member

billyvg commented Jan 18, 2024

I agree with @cleptric irt to bundle size concerns -- I don't think we will add any localization inside of the integration in the short term, but we will make sure that all text is available to be overridden (i.e. we will add the required text to the list of configurable strings).

@yasseralsaidi
Copy link

how ca customize error messages?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 11, 2024
@chargome
Copy link
Member

@yasseralsaidi If your question is not directly related to this issue please open a new issue where you describe the problem you are facing or reach out to us on discord, thank you!

@martijnenco
Copy link

martijnenco commented Nov 2, 2024

Kinda mind-boggling to me that this isn't implemented and not even a MVP to the whole dialog implentation. In my opinion it make it completely useless for all non-english/international customers..

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 2, 2024
@andreiborza
Copy link
Member

@martijnenco thanks for the feedback.

@billyvg is there any update on this issue?

@billyvg
Copy link
Member

billyvg commented Dec 12, 2024

We're lacking customization of the error messages, but everything else is customizable. We will not add any additional localization in the SDK, users will have to provide that themselves. I've created #14687 to track adding error message customization.

@billyvg billyvg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

9 participants