-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Feedback Beta: Localization #10209
Comments
Here are some minor findings from my end:
I'm not sure, why there is an explicit "a" in the English version, but if it is intentional, shouldn't there be an "einen" before "Fehler" in the German translation?
Is there a reason, the German version concatenates the two sentences into one, whereas the English one keeps them separate?
It's nice, that German developers take care of the report immediately (not a very state of the art way of saying that in German btw)—but do English developers do that as well?
I know, Germans are not really known for being polite, but if they want to adhere to the English version, they have to bite the bullet and say "Bitte" as nice as they can 😉 |
I do not support this statement whatsoever! In any case, while I'm not invested in this, I recommend not including any translations out of the box. This is primarily a bundle size concern, and secondly, as we already see in this issue, people might want to translate certain things differently. |
I agree with @cleptric irt to bundle size concerns -- I don't think we will add any localization inside of the integration in the short term, but we will make sure that all text is available to be overridden (i.e. we will add the |
how ca customize error messages? |
@yasseralsaidi If your question is not directly related to this issue please open a new issue where you describe the problem you are facing or reach out to us on discord, thank you! |
Kinda mind-boggling to me that this isn't implemented and not even a MVP to the whole dialog implentation. In my opinion it make it completely useless for all non-english/international customers.. |
@martijnenco thanks for the feedback. @billyvg is there any update on this issue? |
We're lacking customization of the error messages, but everything else is customizable. We will not add any additional localization in the SDK, users will have to provide that themselves. I've created #14687 to track adding error message customization. |
Problem Statement
Is a
locale
setting coming to the configuration options of the widget?We can use https://www.i18next.com/ for internationalization (i18n), localization (l10n) and translation for now, but obviously it would be easier if standard labels for various languages would already be there out of the box
(required)
from Description (required) isn't exposed and therefore not translatable atm...In https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#crash-report-modal
does
lang
[automatic] – override for Sentry’s language code already handle this?This is an almost verbatim copy of my getsentry/sentry#60134 (comment) reposted here in response to @billyvg's comment
Solution Brainstorm
de-DE
for https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#text-customization could be:buttonLabel
submitButtonLabel
cancelButtonLabel
formTitle
nameLabel
namePlaceholder
emailLabel
emailPlaceholder
messageLabel
messagePlaceholder
successMessageText
requiredLabel
de-DE
for In https://docs.sentry.io/platforms/javascript/user-feedback/configuration/#crash-report-modal could be:The text was updated successfully, but these errors were encountered: