Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] Set spans: false in httpIntegration when skipOpenTelemetrySetup: true #14675

Open
lforst opened this issue Dec 12, 2024 · 2 comments
Open

[v9] Set spans: false in httpIntegration when skipOpenTelemetrySetup: true #14675

lforst opened this issue Dec 12, 2024 · 2 comments
Milestone
9.0.0

Comments

@lforst
Copy link
Member

lforst commented Dec 12, 2024

Description

Details outlined in #14660 (comment)
@lforst lforst added this to the 9.0.0 milestone Dec 12, 2024
@mydea
Copy link
Member

mydea commented Dec 12, 2024

Just leaving this here, from some offline discussion: We may do it this way, or some other way - basically, the intent is that for people that disable otel instrumentation, ideally we do not register the HttpInstrumentation by default. How exactly we make this happen, is a bit up for debate...

@mydea
Copy link
Member

mydea commented Dec 12, 2024

For reference, in node-fetch we actually do this automatically - there is no spans option, if tracing is disabled we simply do not emit spans. We could think about doing the same thing for the httpIntegration, so basically get rid of spans option - it was done this way in http because we added this later, so we could not break the behavior of this...

@mydea mydea mentioned this issue Dec 12, 2024
Merged
mydea added a commit that referenced this issue Dec 13, 2024
@mydea
feat(node)!: Avoid http spans by default for custom OTEL setups (#14678)
8b81476 
With this PR, the default value for the `spans` option in the
`httpIntegration` is changed to `false`, if `skipOpenTelemetrySetup:
true` is configured. This is what you'd expect as a user, you do not
want Sentry to register any OTEL instrumentation and emit any spans in
this scenario.

Closes #14675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@mydea @lforst