test(angular): Add Angular 20.0.0-rc.2 e2e test
#16364
Conversation
Lms24
force-pushed
the
lms/test-e2e-angular-20
branch
from
6896251 to
c5184df
Compare
Lms24
requested review from
a team,
mydea,
chargome and
andreiborza
and removed request for
a team and
mydea
| "@angular/animations": "^20.0.0-rc.2", | ||
| "@angular/common": "^20.0.0-rc.2", | ||
| "@angular/compiler": "^20.0.0-rc.2", | ||
| "@angular/core": "^20.0.0-rc.2", |
There was a problem hiding this comment.
wdyt about generally adding canary tests here with "@angular/<package>": "next"?
There was a problem hiding this comment.
we could! Let me take a look how easy this would be. My only concern is that sometimes, it's not just the package versions that need updating but also the app config/module files. But I guess we'd probably see this in the canary tests. Will open a separate PR for canary tests though, as I wanna convert this application to 20 stable when it's released.
There was a problem hiding this comment.
we can use the same format we use for other tests to run this for actual canary, the "normal" tests should not use canary as that may fail and we do not want to block on this!
package.json
Outdated
| @@ -44,7 +44,7 @@ | |||
| "yalc:publish": "lerna run yalc:publish" | |||
| }, | |||
| "volta": { | |||
| "node": "20.18.2", | |||
| "node": "20.19.0", | |||
There was a problem hiding this comment.
let's maybe pull this into a dedicated PR 🤔 wdyt?
There was a problem hiding this comment.
yeah, good point. Still sucks that RR blocks Angular though, I'll try if I can somehow bypass the Node version check in Angular until we figured it out
Opened #16378 for the Node bump
.github/workflows/build.yml
Outdated
| @@ -886,7 +886,13 @@ jobs: | |||
| - uses: pnpm/action-setup@v4 | |||
| with: | |||
| version: 9.4.0 | |||
| - name: Set up Node for Angular 20 | |||
There was a problem hiding this comment.
This is not ideal because we should use the same Node version to build the SDK and to build && run the app. But since we're blocked on upgrading to 20.19.0, I think this is a fair compromise for now.
This PR adds an e2e test for Angular the latest Angular 20 RC. Local testing so far confirms that the SDK works as expected. Let's see if CI is happy as well.
A nice overview of the changes so far in 20: https://www.angular.courses/caniuse?from=19&to=20&hasStatusChange=true
closes #16366