Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feedback): Return when the sendFeedback promise resolves #14683

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(feedback): Return when the sendFeedback promise resolves #14683

merged 4 commits into from
Dec 13, 2024
+1 −1

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Dec 12, 2024 •
edited
Loading

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@antonis antonis marked this pull request as ready for review December 12, 2024 15:45
@antonis antonis requested a review from a team as a code owner December 12, 2024 15:45
@antonis antonis mentioned this pull request Dec 12, 2024
Open
10 tasks
@lforst lforst changed the title fix(feedback): Return when the sendFeedback promise resolves fix(feedback): Return when the sendFeedback promise resolves Dec 12, 2024
lforst
lforst approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

billyvg
billyvg approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! cc @c298lee -- can you follow-up with a test?

@c298lee
Copy link
Member

c298lee commented Dec 12, 2024

Fixes getsentry/sentry#70860

@billyvg
Copy link
Member

billyvg commented Dec 12, 2024

@lforst Hmm, I'm not sure how to get CI running

@lforst lforst merged commit 9e3bc93 into getsentry:develop Dec 13, 2024
110 checks passed
@HazAT HazAT mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea mydea approved these changes

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Feature: User Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antonis @c298lee @billyvg @mydea @lforst