Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin Pytest on Redis tests #3715

Open
szokeasaurusrex opened this issue Oct 29, 2024 · 0 comments · May be fixed by #3703
Open

Unpin Pytest on Redis tests #3715

szokeasaurusrex opened this issue Oct 29, 2024 · 0 comments · May be fixed by #3703
Labels
Component: DX Dealing with developer experience

Comments

@szokeasaurusrex
Copy link
Member

We currently pin pytest for our Redis tests:

sentry-python/tox.ini

Line 585 in bf40090

redis: pytest<8.0.0

Unpinning pytest causes many of the Redis tests to fail. See the status checks on #3703 for details.

It seems that these test failures are occurring because data is leaking between tests. When running just one of the failing tests, the test passes.

Let's investigate what changed in Pytest in version 8.0.0 to cause this change in behavior, and see whether we can remove the version pin.
@szokeasaurusrex szokeasaurusrex mentioned this issue Oct 29, 2024
Closed
@szokeasaurusrex szokeasaurusrex linked a pull request Oct 29, 2024 that will close this issue
test(tox): Unpin pytest on Redis tests #3703
Draft
@antonpirker antonpirker added the Component: DX Dealing with developer experience label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DX Dealing with developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(tox): Unpin pytest on Redis tests getsentry/sentry-python
2 participants
@antonpirker @szokeasaurusrex