-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture an error when a transaction is rejected due to being invalid #3752
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-performance for triage ⏲️ |
Hello @the21st, what SDK are you using that you're running into these size limits with? |
@bcoe we're using the Python SDK. We're running into limits when e.g. we fire a lot of SQL queries (think 400+) within a single transaction. These queries are auto-instrumented as spans by the Sentry SDK automatically. |
Hey @the21st, I'm wondering whether this pops up in your logs? We should be logging an error in the SDK if we receive a reply with a non-200 status code when sending an event to Sentry. (I believe the server would reply with a 400 in case the payload is too big.) That'd be one place to look. You might also be able to see some stats on dropped transactions on the Stats page in the UI. |
@sentrivana what should I search for in our logs? I'll take a look. As for the stats page - yes, I see it there, but that cannot be alerted on, and doesn't give us almost any debugging info for that dropped transaction. |
@the21st logs from the Sentry SDK should be prefixed with |
@szokeasaurusrex thanks! I can see in Sentry stats that there were 5 transactions dropped due to a network error in the last hour but in our logs there are no entries with Edit: I also looked for "Invalid" as a reason for dropping, found 1, searched our logs for that time period, and also found nothing. |
Where exactly are you seeing this information @the21st? A link to the exact page and/or a screenshot of the information would be helpful |
@szokeasaurusrex on the stats page: https://invert.sentry.io/stats/?clientDiscard=true&dataCategory=transactions&environment=prod&project=4507972815028224&statsPeriod=7d . I can send a screenshot in a private channel if there is some. |
@the21st apologies for the back and forth. So yes, it is true that currently we only expose information on things such as invalid transactions, size limits, network errors, etc only on that Stats page. See here for information on all the various types of stats we collect. There are reasons we wouldn't want to automatically create However, I do agree that it makes sense to somehow surface a spike based on those statistics somewhere in the product UX. I will talk internally about this and get back to you. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Problem Statement
Whenever a transaction grows too large, it gets discarded due to being Invalid, since it exceeded the size limit. Currently there's no mechanism that would inform us engineers that this happened.
Solution Brainstorm
Sentry could automatically capture an error in such case, so that we engineers know about this invalid transaction and can fix it.
Product Area
Performance
The text was updated successfully, but these errors were encountered: