Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture an error when a transaction is rejected due to being invalid #3752

Open
the21st opened this issue Nov 5, 2024 · 12 comments
Open

Capture an error when a transaction is rejected due to being invalid #3752

the21st opened this issue Nov 5, 2024 · 12 comments

Comments

@the21st
Copy link

the21st commented Nov 5, 2024

Problem Statement

Whenever a transaction grows too large, it gets discarded due to being Invalid, since it exceeded the size limit. Currently there's no mechanism that would inform us engineers that this happened.

Solution Brainstorm

Sentry could automatically capture an error in such case, so that we engineers know about this invalid transaction and can fix it.

Product Area

Performance

@getsantry
Copy link

getsantry bot commented Nov 5, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link

getsantry bot commented Nov 5, 2024

Routing to @getsentry/product-owners-performance for triage ⏲️

@bcoe
Copy link
Member

bcoe commented Nov 7, 2024

Hello @the21st, what SDK are you using that you're running into these size limits with?

@the21st
Copy link
Author

the21st commented Nov 8, 2024

@bcoe we're using the Python SDK. We're running into limits when e.g. we fire a lot of SQL queries (think 400+) within a single transaction. These queries are auto-instrumented as spans by the Sentry SDK automatically.

@bcoe bcoe transferred this issue from getsentry/sentry Nov 8, 2024
@sentrivana
Copy link
Contributor

sentrivana commented Nov 11, 2024

Hey @the21st, I'm wondering whether this pops up in your logs? We should be logging an error in the SDK if we receive a reply with a non-200 status code when sending an event to Sentry. (I believe the server would reply with a 400 in case the payload is too big.) That'd be one place to look.

You might also be able to see some stats on dropped transactions on the Stats page in the UI.

@the21st
Copy link
Author

the21st commented Nov 11, 2024

@sentrivana what should I search for in our logs? I'll take a look.

As for the stats page - yes, I see it there, but that cannot be alerted on, and doesn't give us almost any debugging info for that dropped transaction.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 11, 2024
@szokeasaurusrex
Copy link
Member

what should I search for in our logs? I'll take a look.

@the21st logs from the Sentry SDK should be prefixed with [sentry].

@the21st
Copy link
Author

the21st commented Nov 12, 2024

@szokeasaurusrex thanks! I can see in Sentry stats that there were 5 transactions dropped due to a network error in the last hour but in our logs there are no entries with [sentry] in them.

Edit: I also looked for "Invalid" as a reason for dropping, found 1, searched our logs for that time period, and also found nothing.

@getsantry getsantry bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 12, 2024
@szokeasaurusrex
Copy link
Member

I can see in Sentry stats that there were 5 transactions dropped

Where exactly are you seeing this information @the21st? A link to the exact page and/or a screenshot of the information would be helpful

@the21st
Copy link
Author

the21st commented Nov 12, 2024

@szokeasaurusrex on the stats page: https://invert.sentry.io/stats/?clientDiscard=true&dataCategory=transactions&environment=prod&project=4507972815028224&statsPeriod=7d . I can send a screenshot in a private channel if there is some.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 12, 2024
@sl0thentr0py
Copy link
Member

@the21st apologies for the back and forth.

So yes, it is true that currently we only expose information on things such as invalid transactions, size limits, network errors, etc only on that Stats page. See here for information on all the various types of stats we collect.

There are reasons we wouldn't want to automatically create errors for each of these because this would mean you would have to pay us (via quota usage) for things that are wrong not in your, i.e. userland code but something within our SDK and our servers. Storing errors/transactions is costly for us (and hence you) so we only do it for actual user problems and collect statistics for our internal problems.

However, I do agree that it makes sense to somehow surface a spike based on those statistics somewhere in the product UX. I will talk internally about this and get back to you.

@getsantry
Copy link

getsantry bot commented Dec 13, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Community
Development

No branches or pull requests

5 participants