Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spotlight): Make Django middleware init even more defensive #3870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 12, 2024

I just got faced with a situation where even trying to do settings.DEBUG may trigger a Django exception if the settings are not loaded yet, hence widening the capture_internal_exceptions() scope for this.

I just got faced with a situation where even trying to do `settings.DEBUG` may trigger a Django exception if the settings are not loaded yet, hence widening the `capture_internal_exceptions()` scope for this.
@BYK BYK enabled auto-merge (squash) December 12, 2024 16:16
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (6448c70) to head (bce9e47).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
- Coverage   79.93%   79.93%   -0.01%     
==========================================
  Files         137      137              
  Lines       15403    15403              
  Branches     2620     2620              
==========================================
- Hits        12313    12312       -1     
- Misses       2217     2219       +2     
+ Partials      873      872       -1     
Files with missing lines Coverage Δ
sentry_sdk/spotlight.py 56.36% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant