-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rake command for adding rails initializer #2218
Comments
If this only targets Rails apps, maybe we can use Rails' generator instead? It also supports cli options. So once this is completed, we can just generate a one line command on the web UI like: bundle exec bin/rails generate sentry --dsn <user DSN> --enable-profiling true |
yep also a possibility! |
We do not enable profiling OOTB with wizards, and there are not prompts as far as I know, to ask the user if they want the wizard to add it. Ruby doesn't have to worry about uploading source context, it automatically sends sessions and attempts to set unique release values. Those would be the typical prompts we'd try to solve for, we should validate the release detection works as we expect. For the DSN there is a login flow, which there are some cases we manage via the wizard well, and some we do not manage well. see -> getsentry/sentry-wizard#357 but this is more related to the org auth token Setup Wizards: dev spec fwiw I don't think detailed feature selection is first prio, but they are considering it for the other wizards as well: getsentry/sentry-wizard#558 Also, after chatting with Neel, I understand the steps for rails set up could become install and configure with this initializer command, which could trigger a CLI wizard like flow is there a way that the install step could be combined? Like what we do with the other wizards?
|
Personally, I wouldn't want to install a npm package just to have it help me set up a SDK, unless it provides significantly better experience. In the Rails community, installing a gem and run its associated Rails generator command for configuration is a pretty standard practice. For example, bugsnag and airbrake have Rails generators too. But I don't think Rails generators can provide the same interactive experience like the wizard does. FWIW, appsignal provides a library-agnostic executable to provide a rich installation or even diagnose experience. This may be closer to what we want to achieve with wizard? That said, IMO this is not something the Ruby SDK team should prioritize the resource for.
Is there any doc or example to show this is achieved? |
fair, we also made it available via
without any insight into how much effort it would be, I don't think it is a high prio either, we can create a different ticket to track it for possible future work
@Lms24 do you have more insights to share about the project selection to fetch the correct DSN? |
we want to make it easier for rails users to setup sentry, see
https://fly.io/docs/reference/sentry/#ruby-on-rails
and
https://github.com/getsentry/sentry-wizard
bundle exec sentry:setup
The text was updated successfully, but these errors were encountered: