Add performance monitoring API #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin-dev/Source/Sentry/Private/Android/Java/SentryBridgeJava.java
|
|
|
||
| void SentrySpanAndroid::RemoveTag(const FString& key) | ||
| { | ||
| SetTag(key, TEXT("")); |
There was a problem hiding this comment.
TIL.
Do you happen to know where this gets filtered? Is that tag still part of the event or does it get removed by the SDK?
There was a problem hiding this comment.
Based on a previous experience with setting extra context for captured events I assume that the "removed" tag is still sent to Sentry however it's not displayed due to its empty value. I wasn't able to find any code in sentry-java that removes it explicitly on the client side but it's hardly confirms my theory
Co-authored-by: Stefan Jandl <[email protected]>
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13