Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process frames marked as in-app by in_app_include rules #79357

Closed
armenzg opened this issue Oct 18, 2024 · 2 comments
Closed

Do not process frames marked as in-app by in_app_include rules #79357

armenzg opened this issue Oct 18, 2024 · 2 comments

Comments

@armenzg
Copy link
Member

armenzg commented Oct 18, 2024

This work depends on this SDK issue resolving.

If the customer uses in_app_include to set some frames as in-app we should not later destroy it with one of our enhancement rules.

For instance, the customer installed their code under their virtual env which ends up under site-packages which we then mark as not an in-app frame. (

)

Once the SDK issue is fixed we can then determine which frames should not be tried for enhancement.

@armenzg
Copy link
Member Author

armenzg commented Oct 22, 2024

Instead of this, we're going to work on #79482.

@armenzg armenzg closed this as completed Oct 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@lobsterkatie
Copy link
Member

Superseded by #83603

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants