Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce size limits in feedback envelope processors #79568

Closed
4 tasks
aliu39 opened this issue Oct 22, 2024 · 2 comments
Closed
4 tasks

Enforce size limits in feedback envelope processors #79568

aliu39 opened this issue Oct 22, 2024 · 2 comments

Comments

@aliu39
Copy link
Member

aliu39 commented Oct 22, 2024

The long-term solution / Follow-up for:

Some context: #79326 (comment)

  • Check for message size limits on the envelope schemas, in rust. Add them if they don't exist. Make sure they're <= 4096 chars as specified in the PR above. (For envelopes we prefer to use bytes.)

    • new feedback (user_report_v2)
    • legacy feedback (user_report)
  • Rather than truncate, emit a rejected outcome for Data Category UserReportV2, and return an error for the SDK.

  • Clean up the feedback max-size option and truncate logic in the previous PR.

A separate size limit could be enforced for spam detection, for COGS. But I wouldn't about it for this issue.

@aliu39 aliu39 changed the title Enforce size limits in feedback envelope schemas Enforce size limits in feedback envelope processors Dec 9, 2024
@aliu39
Copy link
Member Author

aliu39 commented Dec 12, 2024

This can probably be moved to the relay repo

@aliu39
Copy link
Member Author

aliu39 commented Dec 12, 2024

Moved to relay getsentry/relay#4379

@aliu39 aliu39 closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant