Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob Syntax inconsistent in Inbound Filters #81868

Open
kpujjigit opened this issue Dec 9, 2024 · 3 comments
Open

Glob Syntax inconsistent in Inbound Filters #81868

kpujjigit opened this issue Dec 9, 2024 · 3 comments

Comments

@kpujjigit
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Example: say we want to filter out all errors beginning with TypeError1234

  1. Access Inbound Filters under Project Settings > Inbound Filters > Error Message
  2. Trail the Error Message in inbound filters with a wildcard * as intended -> TypeError1234*

Expected Result

All errors beginning with TypeError1234 are filtered.

Actual Result

Trailing an Error Message in inbound filters with a wildcard * as intended, will not work.

Instead, the message needs to be encapsulated in wildcards, like *TypeError1234* even if it's the start of the message.

Product Area

Settings

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Dec 9, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Dec 10, 2024

Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 10, 2024
@Dav1dde
Copy link
Member

Dav1dde commented Dec 10, 2024

This is historic and probably too late to change now because it involves to many already configured rules,

Relay prepends the message which is a matched against the glob with the exception type, e.g. {"ty": "Error", "value": "Foobar XXX"} means your glob must be Error: Foobar* not just Foobar*.

Code here: https://github.com/getsentry/relay/blob/f981d606ef93ab106d902bd4aa5f92c88d56cda8/relay-filter/src/error_messages.rs#L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants