Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish removing pickle parameters from existing tasks #81913

Open
2 tasks
markstory opened this issue Dec 10, 2024 · 0 comments
Open
2 tasks

Finish removing pickle parameters from existing tasks #81913

markstory opened this issue Dec 10, 2024 · 0 comments

Comments

@markstory
Copy link
Member

Before we can move tasks from celery to taskworker they need to not rely on pickle for parameter serialization. There are still a handful of tasks that require pickle for parameters. The tasks in LEGACY_PICKLE_TASKS should be refactored so that they are JSON safe.

  • Update tasks in LEGACY_PICKLE_TASKS to have JSON safe parameters. This will take two deploys for each task to preserve backwards compatibility.
  • Enable CELERY_COMPLAIN_ABOUT_BAD_USE_OF_PICKLE in s4s to further validate that no celery tasks are using pickle parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant