Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Safari Not Being Caught by Legacy Browser Filter #82059

Open
JoshFerge opened this issue Dec 12, 2024 · 0 comments
Open

Mobile Safari Not Being Caught by Legacy Browser Filter #82059

JoshFerge opened this issue Dec 12, 2024 · 0 comments

Comments

@JoshFerge
Copy link
Member

JoshFerge commented Dec 12, 2024

Summary

The inbound legacy browser filter is not catching Mobile Safari 9.0 events, despite being configured to filter Safari versions 11 and lower. This appears to be due to the filter not properly handling Mobile Safari user agents.

Problem Description

Events from Mobile Safari 9.0 are currently bypassing our legacy browser inbound filter when they should be filtered out. The filter is set to handle Safari versions 11 and lower, but is likely only checking desktop Safari user agents.

User Agent:

Mozilla/5.0 (iPad; CPU OS 9_3_6 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G37 Safari/601.1

Technical Details

The filter configuration is set in relay-filter/src/config.rs
Current implementation uses the Safari filter which should catch versions 11 and lower
The issue appears to be that Mobile Safari user agents are not being properly matched by the existing filter logic

Potential Solution

Update the legacy browser filter to properly handle Mobile Safari user agents, ensuring they are caught by the same version rules as desktop Safari.

Additional Context

The legacy browser filters are due for their yearly refresh of version numbers
The fix could potentially be included as part of a broader update to legacy browser filtering rules

Next Steps

Update filtering logic to handle Mobile Safari
Consider including this in the yearly legacy browser version update

Relevant code:

https://github.com/getsentry/relay/blob/1a56dbc5a0b8e5d0ab8b892b0eee097f7165e072/relay-filter/src/legacy_browsers.rs#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant