diff --git a/static/app/views/dashboards/contexts/widgetSyncContext.stories.tsx b/static/app/views/dashboards/contexts/widgetSyncContext.stories.tsx
index 28c4b8a73421a5..e3951f4bdd7531 100644
--- a/static/app/views/dashboards/contexts/widgetSyncContext.stories.tsx
+++ b/static/app/views/dashboards/contexts/widgetSyncContext.stories.tsx
@@ -35,14 +35,6 @@ export default storyBook('WidgetSyncContext', story => {
{visible && (
@@ -50,14 +42,6 @@ export default storyBook('WidgetSyncContext', story => {
)}
diff --git a/static/app/views/dashboards/widgets/common/types.tsx b/static/app/views/dashboards/widgets/common/types.tsx
index 4b5959990400b4..f85d06f7ffd19b 100644
--- a/static/app/views/dashboards/widgets/common/types.tsx
+++ b/static/app/views/dashboards/widgets/common/types.tsx
@@ -17,6 +17,7 @@ export type TimeseriesData = {
data: TimeSeriesItem[];
field: string;
color?: string;
+ meta?: Meta;
};
export type ErrorProp = Error | string;
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.spec.tsx b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.spec.tsx
index 64fcbe832b9e32..0ddf8090e667e3 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.spec.tsx
+++ b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.spec.tsx
@@ -11,14 +11,6 @@ describe('LineChartWidget', () => {
title="eps()"
description="Number of events per second"
timeseries={[sampleDurationTimeSeries]}
- meta={{
- fields: {
- 'eps()': 'rate',
- },
- units: {
- 'eps()': '1/second',
- },
- }}
/>
);
});
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.stories.tsx b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.stories.tsx
index d3cbb4653a4454..f1514355aa495b 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.stories.tsx
+++ b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.stories.tsx
@@ -26,6 +26,14 @@ const sampleDurationTimeSeries2 = {
value: datum.value * 0.3 + 30 * Math.random(),
};
}),
+ meta: {
+ fields: {
+ 'p50(span.duration)': 'duration',
+ },
+ units: {
+ 'p50(span.duration)': 'millisecond',
+ },
+ },
};
export default storyBook(LineChartWidget, story => {
@@ -76,14 +84,6 @@ export default storyBook(LineChartWidget, story => {
title="eps()"
description="Number of events per second"
timeseries={[throughputTimeSeries]}
- meta={{
- fields: {
- 'eps()': 'rate',
- },
- units: {
- 'eps()': '1/second',
- },
- }}
/>
@@ -103,16 +103,6 @@ export default storyBook(LineChartWidget, story => {
shiftTimeserieToNow(durationTimeSeries1),
shiftTimeserieToNow(durationTimeSeries2),
]}
- meta={{
- fields: {
- 'p99(span.duration)': 'duration',
- 'p50(span.duration)': 'duration',
- },
- units: {
- 'p99(span.duration)': 'millisecond',
- 'p50(span.duration)': 'millisecond',
- },
- }}
/>
@@ -172,17 +162,17 @@ export default storyBook(LineChartWidget, story => {
{
...sampleThroughputTimeSeries,
field: 'error_rate()',
+ meta: {
+ fields: {
+ 'error_rate()': 'rate',
+ },
+ units: {
+ 'error_rate()': '1/second',
+ },
+ },
color: theme.error,
} as unknown as TimeseriesData,
]}
- meta={{
- fields: {
- 'error_rate()': 'rate',
- },
- units: {
- 'error_rate()': '1/second',
- },
- }}
/>
@@ -216,17 +206,17 @@ export default storyBook(LineChartWidget, story => {
{
...sampleThroughputTimeSeries,
field: 'error_rate()',
+ meta: {
+ fields: {
+ 'error_rate()': 'rate',
+ },
+ units: {
+ 'error_rate()': '1/second',
+ },
+ },
} as unknown as TimeseriesData,
]}
releases={releases}
- meta={{
- fields: {
- 'error_rate()': 'rate',
- },
- units: {
- 'error_rate()': '1/second',
- },
- }}
/>
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.tsx b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.tsx
index 4936caf8aabbae..e7197ba47d9510 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.tsx
+++ b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidget.tsx
@@ -60,7 +60,6 @@ export function LineChartWidget(props: LineChartWidgetProps) {
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidgetVisualization.tsx b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidgetVisualization.tsx
index fa2d6ada8df637..15a00bf96e4cc2 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidgetVisualization.tsx
+++ b/static/app/views/dashboards/widgets/lineChartWidget/lineChartWidgetVisualization.tsx
@@ -20,7 +20,7 @@ import usePageFilters from 'sentry/utils/usePageFilters';
import {useWidgetSyncContext} from '../../contexts/widgetSyncContext';
import {ReleaseSeries} from '../common/releaseSeries';
-import type {Meta, Release, TimeseriesData} from '../common/types';
+import type {Release, TimeseriesData} from '../common/types';
import {formatTooltipValue} from './formatTooltipValue';
import {formatYAxisValue} from './formatYAxisValue';
@@ -29,7 +29,6 @@ import {splitSeriesIntoCompleteAndIncomplete} from './splitSeriesIntoCompleteAnd
export interface LineChartWidgetVisualizationProps {
timeseries: TimeseriesData[];
dataCompletenessDelay?: number;
- meta?: Meta;
releases?: Release[];
}
@@ -39,7 +38,6 @@ export function LineChartWidgetVisualization(props: LineChartWidgetVisualization
const pageFilters = usePageFilters();
const {start, end, period, utc} = pageFilters.selection.datetime;
- const {meta} = props;
const dataCompletenessDelay = props.dataCompletenessDelay ?? 0;
@@ -95,8 +93,8 @@ export function LineChartWidgetVisualization(props: LineChartWidgetVisualization
// TODO: Raise error if attempting to plot series of different types or units
const firstSeriesField = firstSeries?.field;
- const type = meta?.fields?.[firstSeriesField] ?? 'number';
- const unit = meta?.units?.[firstSeriesField] ?? undefined;
+ const type = firstSeries?.meta?.fields?.[firstSeriesField] ?? 'number';
+ const unit = firstSeries?.meta?.units?.[firstSeriesField] ?? undefined;
const formatter: TooltipFormatterCallback = (
params,
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/sampleDurationTimeSeries.json b/static/app/views/dashboards/widgets/lineChartWidget/sampleDurationTimeSeries.json
index 9a17607b405dca..65ac173fc8b976 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/sampleDurationTimeSeries.json
+++ b/static/app/views/dashboards/widgets/lineChartWidget/sampleDurationTimeSeries.json
@@ -1,5 +1,13 @@
{
"field": "p99(span.duration)",
+ "meta": {
+ "fields": {
+ "p99(span.duration)": "duration"
+ },
+ "units": {
+ "p99(span.duration)": "millisecond"
+ }
+ },
"data": [
{
"value": 163.26759544018776,
diff --git a/static/app/views/dashboards/widgets/lineChartWidget/sampleThroughputTimeSeries.json b/static/app/views/dashboards/widgets/lineChartWidget/sampleThroughputTimeSeries.json
index fcda062750ee1b..eea4cac77dc6f8 100644
--- a/static/app/views/dashboards/widgets/lineChartWidget/sampleThroughputTimeSeries.json
+++ b/static/app/views/dashboards/widgets/lineChartWidget/sampleThroughputTimeSeries.json
@@ -1,5 +1,13 @@
{
"field": "eps()",
+ "meta": {
+ "fields": {
+ "eps()": "rate"
+ },
+ "units": {
+ "eps()": "1/second"
+ }
+ },
"data": [
{
"value": 7456.966666666666,