Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to disable probing GitHub? #1665

Open
grepwood opened this issue Oct 28, 2024 · 7 comments · May be fixed by #1684
Open

Any way to disable probing GitHub? #1665

grepwood opened this issue Oct 28, 2024 · 7 comments · May be fixed by #1684

Comments

@grepwood
Copy link

I'm using sops in a network environment where I will never ever in a million years be able to contact github.com directly. I'd like to be able to call sops -v without it complaining that it can't check what's the latest version.

Is there any environment variable perhaps that controls this behavior?

@grepwood
Copy link
Author

Alright I found myself aliasing sops to sops --disable-version-check.

@felixfontein
Copy link
Contributor

Yes, if you don't want sops -v to contact GitHub, you need to pass --disable-version-check.

@grepwood
Copy link
Author

What kind of REST API call is actually used to get this info? Perhaps I could emulate it from my side of the intranet

@felixfontein
Copy link
Contributor

It tries two approaches (see https://github.com/getsops/sops/blob/main/version/version.go#L136):

@c33s
Copy link

c33s commented Nov 4, 2024

can we please have an environment variable for that? quite uncool that a security tool leaks my ip address without consent.

@nicklasfrahm
Copy link

nicklasfrahm commented Nov 24, 2024

@c33s What should the behaviour of that environment variable be? Would you like it to be an alternative to the --disable-version-check flag?

Can you check if #1684 solves your use-case? Any non-empty value to that environment variable will disable the remote version check.

@c33s
Copy link

c33s commented Nov 25, 2024

@nicklasfrahm yes #1684 is the behavior i was looking for.

still i would vote for opt-in instead of opt-out (eu gdpr): don't contact anything until i explicitly pass a --do-version-check flag or set the variable SOPS_ENABLE_VERSION_CHECK but i assume this would a different issue, would it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants