Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when entity has no IP address #1

Open
mp459 opened this issue Feb 1, 2016 · 2 comments
Open

Breaks when entity has no IP address #1

mp459 opened this issue Feb 1, 2016 · 2 comments

Comments

@mp459
Copy link

mp459 commented Feb 1, 2016

Thanks for putting this together. it's great! It doesn break with a nil error when there is no IP address though. I've changed the code for entity_ip_address to:

    if (webhook['entity']['ip_addresses'].nil?)
          entity_ip_address="not available"
      else
          entity_ip_address = webhook['entity']['ip_addresses']['default']
      end

this should fix it :)

@ginjo
Copy link
Owner

ginjo commented Feb 18, 2016

Cool, thanks - and glad to hear someone is using this! I'll work that fix into the code when I get a chance.

I'm curious: Are you running your own instance of this, or are you using the hosted demo at Heroku?

When I wrote this, I had high hopes of turning it into a general webhook translation/forwarding service, with a set of preconfigured translations, and the ability to add custom translations, to work between any two services (not just Slack and Rackspace). I'd still like to do that, but I wonder if there is already something out there.

@ginjo
Copy link
Owner

ginjo commented Jul 16, 2016

Hey @mp459, I just updated the github repo and the heroku app with your fix for a nil IP. I also made a number of other small fixes and enhancements. Thanks again for the contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants