Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url for PRs are wrong #16

Open
AlexanderBrevig opened this issue Mar 4, 2024 · 1 comment
Open

Url for PRs are wrong #16

AlexanderBrevig opened this issue Mar 4, 2024 · 1 comment
Labels
enhancement New feature or request good-first-issue A good way to get started

Comments

@AlexanderBrevig
Copy link
Member

Currently the LSP will generate an /issues/ URL when completing a PR.

This is because we're using the issues API.
https://github.com/AlexanderBrevig/github-lsp/blob/e5b99c94f233c93fec3aed1936e81218fc816c57/src/backend.rs#L260-L267

Maybe we should use search and filter on is:issue and is:pr, then decorate the cached object in
https://github.com/AlexanderBrevig/github-lsp/blob/e5b99c94f233c93fec3aed1936e81218fc816c57/src/backend.rs#L20
@AlexanderBrevig AlexanderBrevig added bug Something isn't working good-first-issue A good way to get started enhancement New feature or request and removed bug Something isn't working labels Mar 4, 2024
@AlexanderBrevig
Copy link
Member Author

Not marking this as bug, since it is working. GitHub rewrites the URL and points to the correct PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue A good way to get started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexanderBrevig