Update cpp/common/src/codingstandards/cpp/Scope.qll

knewbury01 · rvermeulen · web-flow · commit 3d2e4138d1b3 · 2024-04-02T14:14:24.000-04:00
Co-authored-by: Remco Vermeulen &lt;rvermeulen@users.noreply.github.com&gt;
diff --git a/cpp/common/src/codingstandards/cpp/Scope.qll b/cpp/common/src/codingstandards/cpp/Scope.qll
@@ -274,7 +274,7 @@ predicate hides(UserDeclaration v1, UserDeclaration v2) {
     hides_candidate(v1, mid) and
     hides_candidate(mid, v2)
   ) and
-  //ignore intentional overloads
+  // Unlike `hidesStrict`, that requires a different scope, `hides` considers declarations in the same scope. This will include function overloads based on their name. To remove overloads from consideration, we exclude them.
   not v1.(Function).getAnOverload() = v2
 }
 

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ predicate hides(UserDeclaration v1, UserDeclaration v2) {`
`274`	`274`	`hides_candidate(v1, mid) and`
`275`	`275`	`hides_candidate(mid, v2)`
`276`	`276`	`) and`
`277`		`- //ignore intentional overloads`
	`277`	+ // Unlike `hidesStrict`, that requires a different scope, `hides` considers declarations in the same scope. This will include function overloads based on their name. To remove overloads from consideration, we exclude them.
`278`	`278`	`not v1.(Function).getAnOverload() = v2`
`279`	`279`	`}`
`280`	`280`